73457[TASK] Cleanup code in PSR-14 events
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 112
- typo3/sysext/backend/Classes/Authentication/Event/SwitchUserEvent.php+5 −20
- typo3/sysext/backend/Classes/Backend/Event/ModifyClearCacheActionsEvent.php+1 −6
- typo3/sysext/backend/Classes/Backend/Event/SystemInformationToolbarCollectorEvent.php2+1 −7
- typo3/sysext/backend/Classes/Controller/Event/AfterFormEnginePageInitializedEvent.php+4 −14
- typo3/sysext/backend/Classes/Controller/Event/AfterPageColumnsSelectedForLocalizationEvent.php2+20 −41
- typo3/sysext/backend/Classes/Controller/Event/BeforeFormEnginePageInitializedEvent.php+4 −14
- typo3/sysext/backend/Classes/Controller/Event/ModifyPageLayoutContentEvent.php+4 −6
- typo3/sysext/backend/Classes/History/Event/AfterHistoryRollbackFinishedEvent.php+8 −42
- typo3/sysext/backend/Classes/History/Event/BeforeHistoryRollbackStartEvent.php+7 −35
- typo3/sysext/backend/Classes/LoginProvider/Event/ModifyPageLayoutOnLoginProviderSelectionEvent.php+5 −20
- typo3/sysext/backend/Classes/Search/Event/ModifyQueryForLiveSearchEvent.php+1 −6
- typo3/sysext/core/Classes/Authentication/Event/AfterGroupsResolvedEvent.php+6 −11
- typo3/sysext/core/Classes/Cache/Event/CacheFlushEvent.php+1 −3
- typo3/sysext/core/Classes/Cache/Event/CacheWarmupEvent.php+1 −3
- typo3/sysext/core/Classes/Configuration/Event/AfterTcaCompilationEvent.php+2 −8
- typo3/sysext/core/Classes/Configuration/Event/ModifyLoadedPageTsConfigEvent.php+1 −13
- typo3/sysext/core/Classes/Core/Event/BootCompletedEvent.php+1 −3
- typo3/sysext/core/Classes/Database/Event/AlterTableDefinitionStatementsEvent.php2+2 −8
- typo3/sysext/core/Classes/DataHandling/Event/AppendLinkHandlerElementsEvent.php+8 −36
- typo3/sysext/core/Classes/DataHandling/Event/IsTableExcludedFromReferenceIndexEvent.php+2 −11
Show 92 more files
- typo3/sysext/core/Classes/Html/Event/BrokenLinkAnalysisEvent.php2+11 −26
- typo3/sysext/core/Classes/Imaging/Event/ModifyIconForResourcePropertiesEvent.php+7 −32
- typo3/sysext/core/Classes/Package/Event/AfterPackageActivationEvent.php+5 −20
- typo3/sysext/core/Classes/Package/Event/AfterPackageDeactivationEvent.php+5 −20
- typo3/sysext/core/Classes/Package/Event/BeforePackageActivationEvent.php+1 −7
- typo3/sysext/core/Classes/Page/Event/AbstractBeforeAssetRenderingEvent.php+3 −14
- typo3/sysext/core/Classes/Resource/Event/AfterFileAddedEvent.php+1 −13
- typo3/sysext/core/Classes/Resource/Event/AfterFileAddedToIndexEvent.php+1 −13
- typo3/sysext/core/Classes/Resource/Event/AfterFileCommandProcessedEvent.php+6 −10
- typo3/sysext/core/Classes/Resource/Event/AfterFileContentsSetEvent.php+1 −13
- typo3/sysext/core/Classes/Resource/Event/AfterFileCopiedEvent.php+6 −26
- typo3/sysext/core/Classes/Resource/Event/AfterFileCreatedEvent.php+1 −13
- typo3/sysext/core/Classes/Resource/Event/AfterFileDeletedEvent.php+1 −7
- typo3/sysext/core/Classes/Resource/Event/AfterFileMarkedAsMissingEvent.php+1 −7
- typo3/sysext/core/Classes/Resource/Event/AfterFileMetaDataCreatedEvent.php+5 −20
- typo3/sysext/core/Classes/Resource/Event/AfterFileMetaDataDeletedEvent.php+1 −7
- typo3/sysext/core/Classes/Resource/Event/AfterFileMetaDataUpdatedEvent.php+5 −20
- typo3/sysext/core/Classes/Resource/Event/AfterFileMovedEvent.php+5 −20
- typo3/sysext/core/Classes/Resource/Event/AfterFileProcessingEvent.php+7 −32
- typo3/sysext/core/Classes/Resource/Event/AfterFileRemovedFromIndexEvent.php+1 −7
- typo3/sysext/core/Classes/Resource/Event/AfterFileRenamedEvent.php+1 −13
- typo3/sysext/core/Classes/Resource/Event/AfterFileReplacedEvent.php+1 −13
- typo3/sysext/core/Classes/Resource/Event/AfterFileUpdatedInIndexEvent.php+5 −20
- typo3/sysext/core/Classes/Resource/Event/AfterFolderAddedEvent.php+1 −7
- typo3/sysext/core/Classes/Resource/Event/AfterFolderCopiedEvent.php+5 −20
- typo3/sysext/core/Classes/Resource/Event/AfterFolderDeletedEvent.php+1 −13
- typo3/sysext/core/Classes/Resource/Event/AfterFolderMovedEvent.php+5 −20
- typo3/sysext/core/Classes/Resource/Event/AfterFolderRenamedEvent.php+4 −7
- typo3/sysext/core/Classes/Resource/Event/AfterResourceStorageInitializationEvent.php+1 −7
- typo3/sysext/core/Classes/Resource/Event/BeforeFileAddedEvent.php+7 −32
- typo3/sysext/core/Classes/Resource/Event/BeforeFileContentsSetEvent.php+1 −13
- typo3/sysext/core/Classes/Resource/Event/BeforeFileCopiedEvent.php+1 −13
- typo3/sysext/core/Classes/Resource/Event/BeforeFileCreatedEvent.php+1 −13
- typo3/sysext/core/Classes/Resource/Event/BeforeFileDeletedEvent.php+1 −7
- typo3/sysext/core/Classes/Resource/Event/BeforeFileMovedEvent.php+5 −20
- typo3/sysext/core/Classes/Resource/Event/BeforeFileProcessingEvent.php+7 −32
- typo3/sysext/core/Classes/Resource/Event/BeforeFileRenamedEvent.php+1 −13
- typo3/sysext/core/Classes/Resource/Event/BeforeFileReplacedEvent.php+1 −13
- typo3/sysext/core/Classes/Resource/Event/BeforeFolderAddedEvent.php+1 −13
- typo3/sysext/core/Classes/Resource/Event/BeforeFolderCopiedEvent.php+5 −20
- typo3/sysext/core/Classes/Resource/Event/BeforeFolderDeletedEvent.php+1 −7
- typo3/sysext/core/Classes/Resource/Event/BeforeFolderMovedEvent.php+5 −20
- typo3/sysext/core/Classes/Resource/Event/BeforeFolderRenamedEvent.php+1 −13
- typo3/sysext/core/Classes/Resource/Event/BeforeResourceStorageInitializationEvent.php+1 −19
- typo3/sysext/core/Classes/Resource/Event/EnrichFileMetaDataEvent.php+1 −19
- typo3/sysext/core/Classes/Resource/Event/GeneratePublicUrlForResourceEvent.php2+6 −25
- typo3/sysext/core/Classes/Resource/Event/ModifyFileDumpEvent.php+1 −5
- typo3/sysext/core/Classes/Resource/Event/SanitizeFileNameEvent.php+6 −26
- typo3/sysext/core/Classes/Tree/Event/ModifyTreeDataEvent.php+4 −15
- typo3/sysext/extbase/Classes/Event/Mvc/AfterRequestDispatchedEvent.php+4 −20
- typo3/sysext/extbase/Classes/Event/Mvc/BeforeActionCallEvent.php+5 −20
- typo3/sysext/extbase/Classes/Event/Persistence/AfterObjectThawedEvent.php+1 −13
- typo3/sysext/extbase/Classes/Event/Persistence/EntityAddedToPersistenceEvent.php+1 −7
- typo3/sysext/extbase/Classes/Event/Persistence/EntityFinalizedAfterPersistenceEvent.php+1 −7
- typo3/sysext/extbase/Classes/Event/Persistence/EntityPersistedEvent.php+1 −7
- typo3/sysext/extbase/Classes/Event/Persistence/EntityRemovedFromPersistenceEvent.php+1 −7
- typo3/sysext/extbase/Classes/Event/Persistence/EntityUpdatedInPersistenceEvent.php+1 −7
- typo3/sysext/extbase/Classes/Event/Persistence/ModifyQueryBeforeFetchingObjectDataEvent.php+1 −7
- typo3/sysext/extbase/Classes/Event/Persistence/ModifyResultAfterFetchingObjectDataEvent.php+1 −13
- typo3/sysext/extensionmanager/Classes/Event/AfterExtensionDatabaseContentHasBeenImportedEvent.php+6 −26
- typo3/sysext/extensionmanager/Classes/Event/AfterExtensionFilesHaveBeenImportedEvent.php+5 −20
- typo3/sysext/extensionmanager/Classes/Event/AfterExtensionSiteFilesHaveBeenImportedEvent.php+11 −23
- typo3/sysext/extensionmanager/Classes/Event/AfterExtensionStaticDatabaseContentHasBeenImportedEvent.php+5 −20
- typo3/sysext/extensionmanager/Classes/Event/AvailableActionsForExtensionEvent.php4+6 −15
- typo3/sysext/felogin/Classes/Event/BeforeRedirectEvent.php+4 −14
- typo3/sysext/felogin/Classes/Event/ModifyLoginFormViewEvent.php+1 −4
- typo3/sysext/felogin/Classes/Event/PasswordChangeEvent.php4+7 −29
- typo3/sysext/felogin/Classes/Event/SendRecoveryEmailEvent.php+1 −13
- typo3/sysext/filelist/Classes/Event/ProcessFileListActionsEvent.php+1 −6
- typo3/sysext/frontend/Classes/Authentication/ModifyResolvedFrontendGroupsEvent.php+5 −9
- typo3/sysext/frontend/Classes/Event/FilterMenuItemsEvent.php+9 −28
- typo3/sysext/frontend/Classes/Event/ModifyHrefLangTagsEvent.php2+2 −11
- typo3/sysext/frontend/Classes/Event/ModifyPageLinkConfigurationEvent.php+5 −16
- typo3/sysext/impexp/Classes/Event/BeforeImportEvent.php+1 −7
- typo3/sysext/install/Classes/Service/Event/ModifyLanguagePackRemoteBaseUrlEvent.php+1 −13
- typo3/sysext/linkvalidator/Classes/Event/BeforeRecordIsAnalyzedEvent.php+7 −32
- typo3/sysext/linkvalidator/Classes/Event/ModifyValidatorTaskEmailEvent.php+5 −20
- typo3/sysext/linkvalidator/Classes/EventListener/CheckBrokenRteLinkEventListener.php+1 −7
- typo3/sysext/recordlist/Classes/Event/ModifyRecordListRecordActionsEvent.php+6 −11
- typo3/sysext/recordlist/Classes/Event/RenderAdditionalContentToRecordListEvent.php2+3 −7
- typo3/sysext/redirects/Classes/Event/RedirectWasHitEvent.php+4 −13
- typo3/sysext/rte_ckeditor/Classes/Form/Element/Event/AfterGetExternalPluginsEvent.php+1 −13
- typo3/sysext/rte_ckeditor/Classes/Form/Element/Event/AfterPrepareConfigurationForEditorEvent.php+1 −13
- typo3/sysext/rte_ckeditor/Classes/Form/Element/Event/BeforeGetExternalPluginsEvent.php+1 −13
- typo3/sysext/rte_ckeditor/Classes/Form/Element/Event/BeforePrepareConfigurationForEditorEvent.php+1 −13
- typo3/sysext/seo/Classes/Event/ModifyUrlForCanonicalTagEvent.php+1 −7
- typo3/sysext/setup/Classes/Event/AddJavaScriptModulesEvent.php+1 −1
- typo3/sysext/workspaces/Classes/Event/AfterCompiledCacheableDataForWorkspaceEvent.php+5 −20
- typo3/sysext/workspaces/Classes/Event/AfterDataGeneratedForWorkspaceEvent.php+5 −20
- typo3/sysext/workspaces/Classes/Event/GetVersionedDataEvent.php+7 −32
- typo3/sysext/workspaces/Classes/Event/RetrievedPreviewUrlEvent.php6+7 −45
- typo3/sysext/workspaces/Classes/Event/SortVersionedDataEvent.php+6 −26
Review log 1317
-
Torben Hansen uploaded patch set 1 02/12/22, 18:44
-
core-ci voted on patch set 1 V +1 02/12/22, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23466
-
Nikita Hovratov commented on patch set 1 02/12/22, 20:17
AlterTableDefinitionStatementsEvent.php:27@var array can be removed.BrokenLinkAnalysisEvent.php:31Same as above, @var can be removed, comment can stay.AvailableActionsForExtensionEvent.php:27The @var string[] is actually needed, because it tells us, that the array is an array of strings. phpstan will complain about that at level 6, when we get there.PasswordChangeEvent.php:30This should probably be initialised with = null or getErrorMessage() could result in "access of uninitialised property". -
Chris Müller commented on patch set 1 02/12/22, 21:01
SystemInformationToolbarCollectorEvent.php:30Use constructor property promotion with readonly (and at the other events where it is appropriate). -
Torben Hansen rebased onto patch set 2 02/13/22, 14:27
-
core-ci voted on patch set 2 V +1 02/13/22, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23481
-
Torben Hansen uploaded patch set 3 02/13/22, 18:57
-
Torben Hansen commented on patch set 2 02/13/22, 18:58
SystemInformationToolbarCollectorEvent.php:30ReplyThere are a lot of places for all PSR-14 events where constructor property promotion can be used. I changes the whole patch set to introduce constructor property promotion where appropriate.AfterPageColumnsSelectedForLocalizationEvent.php:34ReplyDoneAlterTableDefinitionStatementsEvent.php:27ReplyDoneBrokenLinkAnalysisEvent.php:31ReplyDoneAvailableActionsForExtensionEvent.php:27ReplyDonePasswordChangeEvent.php:30ReplyDone -
core-ci voted on patch set 3 V +1 02/13/22, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23482
-
Benni Mack voted on patch set 3 CR +1 02/14/22, 07:37
-
Christian Kuhn commented on patch set 3 CR -1 02/14/22, 08:12
GeneratePublicUrlForResourceEvent.php:32private ?string $publicUrl = null; and empty __construct().AvailableActionsForExtensionEvent.php:35no property promotion here?PasswordChangeEvent.php:37no property promotion here?ModifyHrefLangTagsEvent.php:30readonlyRenderAdditionalContentToRecordListEvent.php:32readonlyRetrievedPreviewUrlEvent.php:36readonlyRetrievedPreviewUrlEvent.php:37readonlyRetrievedPreviewUrlEvent.php:39readonly -
Torben Hansen uploaded patch set 4 02/14/22, 10:16
-
Torben Hansen commented on patch set 3 02/14/22, 10:16
GeneratePublicUrlForResourceEvent.php:32ReplyDoneAvailableActionsForExtensionEvent.php:35ReplyDonePasswordChangeEvent.php:37ReplyDoneModifyHrefLangTagsEvent.php:30ReplyDoneRenderAdditionalContentToRecordListEvent.php:32ReplyDoneRetrievedPreviewUrlEvent.php:36ReplyDoneRetrievedPreviewUrlEvent.php:37ReplyDoneRetrievedPreviewUrlEvent.php:39ReplyDone -
core-ci voted on patch set 4 V +1 02/14/22, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23499
-
Christian Kuhn voted on patch set 4 V +1 CR +1 02/14/22, 12:02
-
Benni Mack voted on patch set 4 V +2 CR +2 02/14/22, 12:10
-
Benni Mack merged patch set 5 02/14/22, 12:10
AfterPageColumnsSelectedForLocalizationEvent.php:34