Review main Abandoned Breaking

73463[!!!][TASK] Prepare PageLayoutView removal

Nikita Hovratov CR 0 V 0 Expert +16 −2096 updated 02/19/22, 21:14

Commit message

The old PageLayoutView, which has been scheduled to
be dropped in v11 didn't quite make it, because it
is still used in various hooks. As those hooks still
aren't deprecated, we can't yet drop PageLayoutView
completely. Instead, all unused methods and
properties are removed. What is left, is the factory
method "createFromPageLayoutContext", which is used
to provide an instance of this class in these hooks.

The next logical step would be to deprecate the old
hooks, and, if necessary, replace them with a PSR-14
Event. Finally, PageLayoutView can be dropped in
v13.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 8

Review log 57

  1. Nikita Hovratov uploaded patch set 1 02/13/22, 12:05

  2. core-ci voted on patch set 1 V -1 02/13/22, 12:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23479

  3. Nikita Hovratov uploaded patch set 2 02/13/22, 12:36

  4. core-ci voted on patch set 2 V +1 02/13/22, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23480

  5. Christian Kuhn commented on patch set 2 CR -1 02/14/22, 11:46

    PageLayoutView.php:224

    the problem is here that all this state is useful for hooks to retrieve current state. just removing this state breaks those hooks. the fact that fluid-based-page-module re-used these hooks in the first place really created a huge mess ... maybe coordinate with benni in this area - i'm sure he has some kind of plan on this. and yes, we should really take care PageLayoutView is gone in v12.
  6. Nikita Hovratov commented on patch set 2 02/14/22, 11:51

    PageLayoutView.php:224 Reply Unresolved

    Yep I know, we really missed the opportunity to deprecate those hooks. Just wanted to make some noise, was clear that this won't be merged like this.
  7. Nikita Hovratov abandoned the change 02/19/22, 21:14

    Benni has a plan