Review main Abandoned Breaking

73464[WIP][!!!][TASK] Streamline ResourceCompressor

Benni Mack CR 0 V 0 Hard +45 −270 updated 02/14/22, 16:07

Commit message

ResourceCompressor, responsible for compressing
and concatenating JS and CSS assets, is code-wise
a legacy mess.

Due to several refactorings starting with TYPO3 v7
(where only one entrypoint was used) and TYPO3 v11
where TYPO3 backend now uses URL routing, the functionality
to resolve files relative to the TYPO3 Backend,
and relative to any other file than TYPO3 Public Path
has been removed.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 35

  1. Benni Mack uploaded patch set 1 02/14/22, 07:37

  2. core-ci voted on patch set 1 V -1 02/14/22, 07:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23487

  3. Benni Mack uploaded patch set 2 02/14/22, 08:41

  4. core-ci voted on patch set 2 V -1 02/14/22, 08:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23490

  5. Benni Mack abandoned the change 02/14/22, 16:07

    not going to work