73469[BUGFIX] Prevent undefined array key in ContentObjectRenderer
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 56
-
Georg Ringer uploaded patch set 1 02/14/22, 09:52
-
Georg Ringer commented on patch set 1 02/14/22, 09:52
This change is ready for review. -
core-ci voted on patch set 1 V +1 02/14/22, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23497
-
Oli Bartsch commented on patch set 1 CR -1 02/14/22, 10:24
In which situation does this occur? AFAIK empty() does not trigger any warnings for undefined array key access (https://3v4l.org/DBqAh). -
Christian Kuhn commented on patch set 1 CR -1 02/14/22, 10:57
ContentObjectRenderer.php:5862Unresolvedthat's useless - empty() does not emit notices / warnings. -
Georg Ringer abandoned the change 02/14/22, 19:28
already fixed with https://forge.typo3.org/issues/96816