Review main Merged

7347[BUGFIX] Confusing error message in reports module

Markus Klein CR +2 V +2 Easy +8 −6 updated 06/03/13, 20:49

Commit message

The saltedpasswords status report shows "INSECURE" warnings
although the configuration is totally fine.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
  • Verified V +2
    • Tolleiv Nietsch +2

Files 2

Review log 21

  1. Gerrit wrote 02/08/12, 07:24

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  2. Tolleiv Nietsch merged patch set 1 02/08/12, 07:24

  3. Markus Klein uploaded patch set 2 02/08/12, 07:24

  4. Georg Ringer commented on patch set 2 02/08/12, 07:24

    Verified; Looks good to me, but someone else must approve
  5. Steffen Ritter commented on patch set 2 V 0 02/08/12, 07:24

    by team member

    class.tx_saltedpasswords_emconfhelper.php:268

    salted passwords disabled is not an info! it is unsecure!
  6. Steffen Ritter commented on patch set 2 02/08/12, 07:24

    (1 inline comment)
  7. Steffen Ritter commented on patch set 2 1 comment 02/08/12, 07:24

    Verified; I would prefer that you didn't submit this works as announced BUT: not enabled saltedpasswords is not a info, its unsecure... see inline comment
  8. Philipp Gampe commented on patch set 2 02/08/12, 07:24

    (1 inline comment)

    class.tx_saltedpasswords_emconfhelper.php:268 Reply

    what is wrong with warning? Should it be error?
  9. Tolleiv Nietsch commented on patch set 3 V 0 02/08/12, 07:24

    by team member; Looks good to me, approved
  10. Tolleiv Nietsch uploaded patch set 4 02/08/12, 07:24

  11. Tolleiv Nietsch commented on patch set 4 V 0 02/08/12, 07:24

    by team member; Looks good to me, approved
  12. Markus Klein commented on patch set 3 02/08/12, 07:24

    Test on 4.6, it's the same.
  13. Georg Ringer commented on patch set 3 02/08/12, 07:24

    Verified; Looks good to me, but someone else must approve
  14. Philipp Gampe commented on patch set 3 02/08/12, 07:24

    Looks good to me, but someone else must approve
  15. Philipp Gampe uploaded patch set 3 02/08/12, 07:24

  16. Philipp Gampe commented on patch set 3 02/08/12, 07:24

    I changed it to "error" if the extension is not installed. I could not test the other change, because EM is still broken.
  17. Viktor Livakivskyi commented on patch set 2 02/08/12, 07:24

    Verified; Looks good to me, but someone else must approve Yes, now the severity level is ok.
  18. Mr. Jenkins commented on patch set 1 02/08/12, 07:24

  19. Mr. Jenkins commented on patch set 2 02/08/12, 07:24

  20. Mr. Jenkins commented on patch set 3 02/08/12, 07:24

  21. Mr. Jenkins commented on patch set 4 02/08/12, 07:24