7347[BUGFIX] Confusing error message in reports module
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
-
Verified V +2
- Tolleiv Nietsch +2
Files 2
Review log 21
-
Gerrit wrote 02/08/12, 07:24
Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review. -
Tolleiv Nietsch merged patch set 1 02/08/12, 07:24
-
Markus Klein uploaded patch set 2 02/08/12, 07:24
-
Georg Ringer commented on patch set 2 02/08/12, 07:24
Verified; Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 2 V 0 02/08/12, 07:24
by team memberclass.tx_saltedpasswords_emconfhelper.php:268salted passwords disabled is not an info! it is unsecure! -
Steffen Ritter commented on patch set 2 02/08/12, 07:24
(1 inline comment) -
Steffen Ritter commented on patch set 2 1 comment 02/08/12, 07:24
Verified; I would prefer that you didn't submit this works as announced BUT: not enabled saltedpasswords is not a info, its unsecure... see inline comment -
Philipp Gampe commented on patch set 2 02/08/12, 07:24
(1 inline comment)class.tx_saltedpasswords_emconfhelper.php:268Replywhat is wrong with warning? Should it be error? -
Tolleiv Nietsch commented on patch set 3 V 0 02/08/12, 07:24
by team member; Looks good to me, approved -
Tolleiv Nietsch uploaded patch set 4 02/08/12, 07:24
-
Tolleiv Nietsch commented on patch set 4 V 0 02/08/12, 07:24
by team member; Looks good to me, approved -
Markus Klein commented on patch set 3 02/08/12, 07:24
Test on 4.6, it's the same. -
Georg Ringer commented on patch set 3 02/08/12, 07:24
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 3 02/08/12, 07:24
Looks good to me, but someone else must approve -
Philipp Gampe uploaded patch set 3 02/08/12, 07:24
-
Philipp Gampe commented on patch set 3 02/08/12, 07:24
I changed it to "error" if the extension is not installed. I could not test the other change, because EM is still broken. -
Viktor Livakivskyi commented on patch set 2 02/08/12, 07:24
Verified; Looks good to me, but someone else must approve Yes, now the severity level is ok. -
Mr. Jenkins commented on patch set 1 02/08/12, 07:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2781/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/08/12, 07:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2783/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/08/12, 07:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2804/ : SUCCESS -
Mr. Jenkins commented on patch set 4 02/08/12, 07:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3153/ : SUCCESS