Review main Merged

73473[TASK] Streamline EXT:tstemplate controllers

Benni Mack CR +2 V +2 Hard +135 −269 updated 02/14/22, 12:26

Commit message

This change is a pre-patch for introducing
https://review.typo3.org/c/Packages/TYPO3.CMS/+/73339

to allow to reduce the calls to $pObj
by using inheritance for all controllers
related to TypoScript parsing in "Web > Template"

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1216

  1. Benni Mack uploaded patch set 1 02/14/22, 10:40

  2. core-ci voted on patch set 1 V -1 02/14/22, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23503

  3. Oli Bartsch uploaded patch set 2 02/14/22, 11:28

  4. core-ci voted on patch set 2 V +1 02/14/22, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23507

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 02/14/22, 11:58

  6. Christian Kuhn commented on patch set 2 02/14/22, 11:58

    TypoScriptTemplateModuleController.php:157

    out?
  7. Christian Kuhn commented on patch set 2 CR -1 02/14/22, 11:59

    i know what you're doing. pre-patch is fine for me. testing feels good. minor glitches on reading.
    needs issue.
  8. Oli Bartsch uploaded patch set 3 02/14/22, 12:07

  9. Oli Bartsch commented on patch set 3 V +1 CR +1 02/14/22, 12:07

    Reply

    Done
  10. Benni Mack commented on patch set 4 02/14/22, 12:12

    Published edit on patch set 3.
  11. Benni Mack commented on patch set 4 02/14/22, 12:13

    TypoScriptTemplateModuleController.php:157 Reply

    Done
  12. core-ci voted on patch set 3 V +1 02/14/22, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23508

  13. Oli Bartsch voted on patch set 4 V +1 CR +1 02/14/22, 12:21

  14. core-ci voted on patch set 4 V +1 02/14/22, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23509

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 02/14/22, 12:25

  16. Christian Kuhn merged patch set 5 02/14/22, 12:26