73473[TASK] Streamline EXT:tstemplate controllers
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 9
- Build/phpstan/phpstan-baseline.neon+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerController.phprenamed+16 −49
- typo3/sysext/tstemplate/Classes/Controller/TyposcriptConstantEditorController.phprenamed+18 −55
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptObjectBrowserController.phprenamed+45 −87
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateInformationController.phprenamed+7 −51
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php2+25 −15
- typo3/sysext/tstemplate/Configuration/Services.yaml+12 −0
- typo3/sysext/tstemplate/Tests/Unit/Controller/TypoScriptObjectBrowserControllerTest.phprenamed+3 −3
- typo3/sysext/tstemplate/ext_tables.php+8 −8
Review log 1216
-
Benni Mack uploaded patch set 1 02/14/22, 10:40
-
core-ci voted on patch set 1 V -1 02/14/22, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23503
-
Oli Bartsch uploaded patch set 2 02/14/22, 11:28
-
core-ci voted on patch set 2 V +1 02/14/22, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23507
-
Oli Bartsch voted on patch set 2 V +1 CR +1 02/14/22, 11:58
-
Christian Kuhn commented on patch set 2 02/14/22, 11:58
-
Christian Kuhn commented on patch set 2 CR -1 02/14/22, 11:59
i know what you're doing. pre-patch is fine for me. testing feels good. minor glitches on reading.needs issue. -
Oli Bartsch uploaded patch set 3 02/14/22, 12:07
-
Oli Bartsch commented on patch set 3 V +1 CR +1 02/14/22, 12:07
Reply
Done -
Benni Mack commented on patch set 4 02/14/22, 12:12
Published edit on patch set 3. -
Benni Mack commented on patch set 4 02/14/22, 12:13
TypoScriptTemplateModuleController.php:157ReplyDone -
core-ci voted on patch set 3 V +1 02/14/22, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23508
-
Oli Bartsch voted on patch set 4 V +1 CR +1 02/14/22, 12:21
-
core-ci voted on patch set 4 V +1 02/14/22, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23509
-
Christian Kuhn voted on patch set 4 V +2 CR +2 02/14/22, 12:25
-
Christian Kuhn merged patch set 5 02/14/22, 12:26
TypoScriptTemplateModuleController.php:157