Review main Merged

73474[BUGFIX] Make custom table styles more explicit

Oli Bartsch CR +2 V +2 Easy +20 −18 updated 02/14/22, 13:49

Commit message

To overwrite the bootstrap styles of the striped
table in the extension manager list, our custom
styles must be defined more explicit.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 78

  1. Oli Bartsch uploaded patch set 1 02/14/22, 11:14

  2. core-ci voted on patch set 1 V +1 02/14/22, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23505

  3. Christian Kuhn commented on patch set 1 02/14/22, 11:37

    there was a similar change a while ago regarding 'marking rows as red for extensions marked as security issue' - let's double check we don't break this again when fiddling on row stuff again.
  4. Oli Bartsch commented on patch set 1 02/14/22, 11:42

    Reply

    Yes, changes were done to the same place (adding styles to td explicitly): https://review.typo3.org/c/Packages/TYPO3.CMS/+/67462. Checked this and works like before.
  5. Georg Ringer voted on patch set 1 V +1 CR +1 02/14/22, 12:10

  6. Benni Mack voted on patch set 1 V +1 CR +1 02/14/22, 13:20

  7. Oli Bartsch voted on patch set 1 V +2 CR +2 02/14/22, 13:49

  8. Oli Bartsch merged patch set 2 02/14/22, 13:49