73475[!!!][FEATURE] Move Cache Lifetime Calculation into its own class
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96879-RemovedHookGetCacheTimeout.rstnew+36 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96879-NewPSR-14EventModifyCacheLifetimeForPageEvent.rstnew+51 −0
- typo3/sysext/frontend/Classes/Cache/CacheLifetimeCalculator.php4new+221 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+11 −176
- typo3/sysext/frontend/Classes/Event/ModifyCacheLifetimeForPageEvent.php2new+66 −0
- typo3/sysext/frontend/Configuration/Services.yaml+5 −0
- typo3/sysext/frontend/Tests/Functional/Cache/CacheLifetimeCalculatorTest.phpnew+76 −0
- typo3/sysext/frontend/Tests/Functional/Cache/fixtures.csvrenamed+0 −0
- typo3/sysext/frontend/Tests/Functional/Controller/TypoScriptFrontendControllerTest.phpdeleted+0 −98
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+5 −0
Review log 2333
Show 78 earlier messages
-
Benni Mack uploaded patch set 1 02/14/22, 11:16
-
Mathias Brodala commented on patch set 1 02/14/22, 11:25
-
Chris Müller commented on patch set 1 CR -1 02/14/22, 11:30
ModifyCacheTimoutForPageEvent.php:22Missing e: ModifyCacheTimeoutForPageEventModifyCacheTimoutForPageEvent.php:26Should these properties (without $cacheTimeout) declared readonly? -
Benni Mack uploaded patch set 2 02/14/22, 12:52
-
Benni Mack updated the commit message in patch set 3 02/14/22, 12:53
-
Benni Mack uploaded patch set 4 02/14/22, 13:01
-
Benni Mack commented on patch set 4 02/14/22, 13:02
CacheTimoutCalculator.php:34ReplyDoneModifyCacheTimoutForPageEvent.php:22ReplyDoneModifyCacheTimoutForPageEvent.php:26ReplyDone -
core-ci voted on patch set 2 V -1 02/14/22, 13:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23510
-
core-ci voted on patch set 3 V -1 02/14/22, 13:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23511
-
core-ci voted on patch set 4 V -1 02/14/22, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23512
-
core-ci voted on patch set 1 V -1 02/14/22, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23506
-
Benni Mack uploaded patch set 5 02/14/22, 13:39
-
core-ci voted on patch set 5 V -1 02/14/22, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23514
-
Benni Mack uploaded patch set 6 02/14/22, 19:03
-
core-ci voted on patch set 6 V +1 02/14/22, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23551
-
Benni Mack uploaded patch set 7 02/15/22, 08:00
-
core-ci voted on patch set 7 V +1 02/15/22, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23589
-
Oli Bartsch commented on patch set 7 02/15/22, 08:48
ModifyCacheLifetimeForPageEvent.php:22Should be final. Also a Short description, "Listeners to this event are able to ..." would be nice. -
Benni Mack commented on patch set 8 02/15/22, 08:50
Published edit on patch set 7. -
Benni Mack commented on patch set 8 02/15/22, 08:50
ModifyCacheLifetimeForPageEvent.php:22ReplyDone -
Stefan Bürk commented on patch set 8 02/15/22, 10:01
CacheLifetimeCalculator.php:48Left over / uncomplete sentence ? Looks weired ...CacheLifetimeCalculator.php:161Can we inject 'ConnectionPool' through DI in this new class and avoid GU::makeInstance() ? -
Benni Mack uploaded patch set 9 02/15/22, 10:15
-
Benni Mack commented on patch set 8 02/15/22, 10:15
CacheLifetimeCalculator.php:48ReplyDoneCacheLifetimeCalculator.php:161ReplyDone -
Oli Bartsch uploaded patch set 10 02/15/22, 10:33
-
core-ci voted on patch set 10 V -1 02/15/22, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23609
-
core-ci voted on patch set 8 V -1 02/15/22, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23593
-
Oli Bartsch uploaded patch set 11 02/15/22, 11:36
-
core-ci voted on patch set 11 V +1 02/15/22, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23613
-
Oli Bartsch commented on patch set 11 V +1 CR +1 02/15/22, 11:55
On it -
Oli Bartsch commented on patch set 11 02/15/22, 11:57
Reply
Finished ;) -
Stefan Bürk voted on patch set 11 V +1 CR +1 02/15/22, 12:09
-
Benni Mack voted on patch set 11 V +2 CR +2 02/15/22, 12:11
-
Benni Mack merged patch set 12 02/15/22, 12:12
CacheTimoutCalculator.php:34