Review main Merged

73477[TASK] Harden TSFE->id related code

Benni Mack CR +2 V +2 Normal +66 −109 updated 02/14/22, 21:18

Commit message

This change cleans up some functionality
regarding TSFE when SiteHandling was introduced
in TYPO3 v9:

* TSFE->id is always an integer now
* TSFE->contentPid and TSFE->requestedId now as well
* TSFE->site is always of type Site (not SiteInterface) anymore
* Some TSFE related methods now need the PSR-7 request (as defined before already)

Other places such as $TSFE->type will be worked
on separately.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 813

  1. Benni Mack uploaded patch set 1 02/14/22, 14:00

  2. core-ci voted on patch set 1 V -1 02/14/22, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23516

  3. Benni Mack uploaded patch set 2 02/14/22, 14:33

  4. core-ci voted on patch set 2 V +1 02/14/22, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23519

  5. Benni Mack updated the commit message in patch set 3 02/14/22, 15:22

  6. core-ci voted on patch set 3 V +1 02/14/22, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23526

  7. Benni Mack uploaded patch set 4 02/14/22, 16:26

  8. core-ci voted on patch set 4 V +1 02/14/22, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23531

  9. Benni Mack uploaded patch set 5 02/14/22, 17:33

  10. core-ci voted on patch set 5 V +1 02/14/22, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23540

  11. Stefan Bürk voted on patch set 5 V +1 CR +1 02/14/22, 21:18

  12. Christian Kuhn voted on patch set 5 V +2 CR +2 02/14/22, 21:18

  13. Christian Kuhn merged patch set 6 02/14/22, 21:18