73477[TASK] Harden TSFE->id related code
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 9
- Build/phpstan/phpstan-baseline.neon+0 −25
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+2 −2
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+31 −58
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+5 −11
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+21 −6
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+1 −1
- typo3/sysext/seo/Classes/Canonical/CanonicalGenerator.php+2 −2
- typo3/sysext/seo/Classes/HrefLang/HrefLangGenerator.php+3 −3
Review log 813
-
Benni Mack uploaded patch set 1 02/14/22, 14:00
-
core-ci voted on patch set 1 V -1 02/14/22, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23516
-
Benni Mack uploaded patch set 2 02/14/22, 14:33
-
core-ci voted on patch set 2 V +1 02/14/22, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23519
-
Benni Mack updated the commit message in patch set 3 02/14/22, 15:22
-
core-ci voted on patch set 3 V +1 02/14/22, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23526
-
Benni Mack uploaded patch set 4 02/14/22, 16:26
-
core-ci voted on patch set 4 V +1 02/14/22, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23531
-
Benni Mack uploaded patch set 5 02/14/22, 17:33
-
core-ci voted on patch set 5 V +1 02/14/22, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23540
-
Stefan Bürk voted on patch set 5 V +1 CR +1 02/14/22, 21:18
-
Christian Kuhn voted on patch set 5 V +2 CR +2 02/14/22, 21:18
-
Christian Kuhn merged patch set 6 02/14/22, 21:18