Review 11.5 Merged

73478[BUGFIX] Catch non-okayish responses in Modal requests

Benjamin Franzke CR +2 V +2 Easy +17 −4 updated 02/14/22, 15:07

Commit message

If the modal component starts an AJAX request that results in a
non-okayish response (>= 400), the underlying fetch() throws an error
that is now caught.

If the response sends an optional body, it is rendered in the modal. If
an empty body is received, a fallback text explaining the issue is
rendered instead.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 23

  1. Benjamin Franzke uploaded patch set 1 02/14/22, 14:56

  2. core-ci voted on patch set 1 V +1 02/14/22, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23522

  3. Benjamin Franzke merged patch set 2 02/14/22, 15:07