Review main Merged Breaking

73479[!!!][FEATURE] Replace hook in About module with PSR-14 event

Benni Mack CR +2 V +2 Hard +232 −116 updated 02/15/22, 19:06

Commit message

A new PSR-14 event "ModifyGenericBackendMessagesEvent"
is added when collecting (warning) messages in TYPO3
Backend's About Module.

The Event is added as direct replacement for the hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_befunc.php']['displayWarningMessages']

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1014

  1. Benni Mack uploaded patch set 1 02/14/22, 15:15

  2. core-ci voted on patch set 1 V +1 02/14/22, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23524

  3. Benni Mack updated the commit message in patch set 2 02/15/22, 08:58

  4. core-ci voted on patch set 2 V +1 02/15/22, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23595

  5. Benni Mack uploaded patch set 3 02/15/22, 14:33

  6. core-ci voted on patch set 3 V +1 02/15/22, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23626

  7. Oli Bartsch commented on patch set 3 02/15/22, 15:32

    Index.html:15

    Shouldn't we use state="1" here?

    Breaking-96899-DisplayWarningMessagesHookRemoved.rst:22

    Actually this reads as using the hook will make the whole extension inactive. Maybe just: "Registered hooks are not executed anymore."

    Breaking-96899-DisplayWarningMessagesHookRemoved.rst:36

    This is duplicated in the sentence and should probably be removed.

    WarningsForAboutModule.php:62

    This link does not seem to be displayed.
  8. Oli Bartsch uploaded patch set 4 02/15/22, 17:47

  9. Oli Bartsch commented on patch set 4 02/15/22, 17:48

    Index.html:15 Reply

    Done

    Breaking-96899-DisplayWarningMessagesHookRemoved.rst:22 Reply

    Done

    Breaking-96899-DisplayWarningMessagesHookRemoved.rst:36 Reply

    Done

    WarningsForAboutModule.php:62 Reply

    Done
  10. core-ci voted on patch set 4 V +1 02/15/22, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23647

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 02/15/22, 18:02

  12. Stefan Bürk voted on patch set 4 V +1 CR +1 02/15/22, 18:48

  13. Georg Ringer voted on patch set 4 V +2 CR +2 02/15/22, 19:06

  14. Georg Ringer merged patch set 5 02/15/22, 19:06