73479[!!!][FEATURE] Replace hook in About module with PSR-14 event
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/backend/Classes/Controller/Event/ModifyGenericBackendMessagesEvent.phpnew+43 −0
- typo3/sysext/backend/Classes/Controller/AboutController.php+7 −13
- typo3/sysext/backend/Resources/Private/Partials/About/About.html+2 −2
- typo3/sysext/backend/Resources/Private/Partials/About/Logo.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/About/Index.html2+5 −20
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96899-DisplayWarningMessagesHookRemoved.rst4new+39 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96899-NewPSR-14EventModifyGenericBackendMessagesEvent.rstnew+53 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+5 −0
- typo3/sysext/reports/Classes/Report/Status/WarningMessagePostProcessor.phpdeleted+0 −77
- typo3/sysext/reports/Classes/Report/WarningsForAboutModule.php2new+72 −0
- typo3/sysext/reports/Configuration/Services.yaml+5 −0
- typo3/sysext/reports/ext_localconf.php+0 −3
Review log 1014
-
Benni Mack uploaded patch set 1 02/14/22, 15:15
-
core-ci voted on patch set 1 V +1 02/14/22, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23524
-
Benni Mack updated the commit message in patch set 2 02/15/22, 08:58
-
core-ci voted on patch set 2 V +1 02/15/22, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23595
-
Benni Mack uploaded patch set 3 02/15/22, 14:33
-
core-ci voted on patch set 3 V +1 02/15/22, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23626
-
Oli Bartsch commented on patch set 3 02/15/22, 15:32
Breaking-96899-DisplayWarningMessagesHookRemoved.rst:22Actually this reads as using the hook will make the whole extension inactive. Maybe just: "Registered hooks are not executed anymore."Breaking-96899-DisplayWarningMessagesHookRemoved.rst:36This is duplicated in the sentence and should probably be removed.WarningsForAboutModule.php:62This link does not seem to be displayed. -
Oli Bartsch uploaded patch set 4 02/15/22, 17:47
-
Oli Bartsch commented on patch set 4 02/15/22, 17:48
Index.html:15ReplyDoneBreaking-96899-DisplayWarningMessagesHookRemoved.rst:22ReplyDoneBreaking-96899-DisplayWarningMessagesHookRemoved.rst:36ReplyDoneWarningsForAboutModule.php:62ReplyDone -
core-ci voted on patch set 4 V +1 02/15/22, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23647
-
Oli Bartsch voted on patch set 4 V +1 CR +1 02/15/22, 18:02
-
Stefan Bürk voted on patch set 4 V +1 CR +1 02/15/22, 18:48
-
Georg Ringer voted on patch set 4 V +2 CR +2 02/15/22, 19:06
-
Georg Ringer merged patch set 5 02/15/22, 19:06
Index.html:15