Review main Merged

73482[BUGFIX] Fix phpstan-related issues in EXT:frontend

Benni Mack CR +2 V +2 Normal +21 −92 updated 03/07/22, 21:48

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1827

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 02/14/22, 17:32

  2. core-ci voted on patch set 1 V -1 02/14/22, 17:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23539

  1. Benni Mack uploaded patch set 2 02/14/22, 22:00

  2. Benni Mack uploaded patch set 3 02/14/22, 22:03

  3. core-ci voted on patch set 2 V +1 02/14/22, 22:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23574

  4. core-ci voted on patch set 3 V +1 02/14/22, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23575

  5. Christian Kuhn commented on patch set 3 02/14/22, 22:17

    PrepareTypoScriptFrontendRendering.php:55

    swap TypoScriptFrontendController and $controller
  6. Christian Kuhn commented on patch set 3 02/14/22, 22:23

    FrontendConfigurationManager.php:129

    maybe use intExplode() instead to save the int cast?

    FrontendUserAuthentication.php:370

    sure? if you're sure, then this property should have an array hint.

    FilesProcessor.php:71

    not save on reading.

    PageResolver.php:62

    obsolete, is it? i think phpstan is meanwhile configured to know these?
  7. Christian Kuhn commented on patch set 3 02/14/22, 22:25

    PageResolver.php:62 Reply

    actually, keep this as done now.
  8. Stefan Bürk uploaded patch set 4 02/16/22, 14:51

  9. Stefan Bürk commented on patch set 4 02/16/22, 14:53

    fixed 2 comments from lollie and updated phpstan (removing added ignorePattern again).

    FrontendConfigurationManager.php:129 Reply

    Done

    PrepareTypoScriptFrontendRendering.php:55 Reply

    Done
  10. core-ci voted on patch set 4 V +1 02/16/22, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23729

  11. Stefan Bürk uploaded patch set 5 03/07/22, 14:09

  12. core-ci voted on patch set 5 V +1 03/07/22, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24659

  13. Benni Mack commented on patch set 6 03/07/22, 17:10

    Published edit on patch set 5.
  14. Benni Mack commented on patch set 7 03/07/22, 17:10

    Published edit on patch set 6.
  15. Benni Mack commented on patch set 7 03/07/22, 17:10

    FrontendUserAuthentication.php:370 Reply

    Done

    FilesProcessor.php:71 Reply

    Done
  16. core-ci voted on patch set 6 V -1 03/07/22, 17:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24671

  17. core-ci voted on patch set 7 V -1 03/07/22, 17:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24672

  18. Benni Mack uploaded patch set 8 03/07/22, 18:01

  19. core-ci voted on patch set 8 V +1 03/07/22, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24677

  20. Stefan Bürk uploaded patch set 9 03/07/22, 21:22

  21. Stefan Bürk voted on patch set 9 V +1 CR +1 03/07/22, 21:31

  22. core-ci voted on patch set 9 V +1 03/07/22, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24692

  23. Georg Ringer voted on patch set 9 V +1 CR +1 03/07/22, 21:47

  24. Georg Ringer voted on patch set 9 V +2 CR +2 03/07/22, 21:47

  25. Georg Ringer merged patch set 10 03/07/22, 21:48