73482[BUGFIX] Fix phpstan-related issues in EXT:frontend
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Stefan Bürk +1
-
Verified V +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 12
- Build/phpstan/phpstan-baseline.neon+1 −55
- typo3/sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php2+2 −5
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/frontend/Classes/DataProcessing/CommaSeparatedValueProcessor.php+1 −1
- typo3/sysext/frontend/Classes/DataProcessing/DatabaseQueryProcessor.php+1 −2
- typo3/sysext/frontend/Classes/DataProcessing/FilesProcessor.php2+5 −6
- typo3/sysext/frontend/Classes/DataProcessing/LanguageMenuProcessor.php+2 −2
- typo3/sysext/frontend/Classes/DataProcessing/SplitProcessor.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/EidHandler.php+4 −13
- typo3/sysext/frontend/Classes/Middleware/FrontendUserAuthenticator.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/PageResolver.php2+1 −1
- typo3/sysext/frontend/Classes/Page/CacheHashCalculator.php+1 −4
Review log 1827
Show 12 earlier messages
-
Benni Mack uploaded patch set 1 02/14/22, 17:32
-
core-ci voted on patch set 1 V -1 02/14/22, 17:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23539
-
Benni Mack uploaded patch set 2 02/14/22, 22:00
-
Benni Mack uploaded patch set 3 02/14/22, 22:03
-
core-ci voted on patch set 2 V +1 02/14/22, 22:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23574
-
core-ci voted on patch set 3 V +1 02/14/22, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23575
-
Christian Kuhn commented on patch set 3 02/14/22, 22:17
-
Christian Kuhn commented on patch set 3 02/14/22, 22:23
FrontendConfigurationManager.php:129maybe use intExplode() instead to save the int cast?FrontendUserAuthentication.php:370sure? if you're sure, then this property should have an array hint.FilesProcessor.php:71not save on reading.PageResolver.php:62obsolete, is it? i think phpstan is meanwhile configured to know these? -
Christian Kuhn commented on patch set 3 02/14/22, 22:25
PageResolver.php:62Replyactually, keep this as done now. -
Stefan Bürk uploaded patch set 4 02/16/22, 14:51
-
Stefan Bürk commented on patch set 4 02/16/22, 14:53
fixed 2 comments from lollie and updated phpstan (removing added ignorePattern again).FrontendConfigurationManager.php:129ReplyDonePrepareTypoScriptFrontendRendering.php:55ReplyDone -
core-ci voted on patch set 4 V +1 02/16/22, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23729
-
Stefan Bürk uploaded patch set 5 03/07/22, 14:09
-
core-ci voted on patch set 5 V +1 03/07/22, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24659
-
Benni Mack commented on patch set 6 03/07/22, 17:10
Published edit on patch set 5. -
Benni Mack commented on patch set 7 03/07/22, 17:10
Published edit on patch set 6. -
Benni Mack commented on patch set 7 03/07/22, 17:10
FrontendUserAuthentication.php:370ReplyDoneFilesProcessor.php:71ReplyDone -
core-ci voted on patch set 6 V -1 03/07/22, 17:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24671
-
core-ci voted on patch set 7 V -1 03/07/22, 17:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24672
-
Benni Mack uploaded patch set 8 03/07/22, 18:01
-
core-ci voted on patch set 8 V +1 03/07/22, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24677
-
Stefan Bürk uploaded patch set 9 03/07/22, 21:22
-
Stefan Bürk voted on patch set 9 V +1 CR +1 03/07/22, 21:31
-
core-ci voted on patch set 9 V +1 03/07/22, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24692
-
Georg Ringer voted on patch set 9 V +1 CR +1 03/07/22, 21:47
-
Georg Ringer voted on patch set 9 V +2 CR +2 03/07/22, 21:47
-
Georg Ringer merged patch set 10 03/07/22, 21:48
PrepareTypoScriptFrontendRendering.php:55