73483[TASK] Streamline TSFE-related config properties
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1114
-
Benni Mack uploaded patch set 1 02/14/22, 17:43
-
core-ci voted on patch set 1 V -1 02/14/22, 17:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23543
-
Benni Mack uploaded patch set 2 02/14/22, 18:58
-
core-ci voted on patch set 2 V +1 02/14/22, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23550
-
Christian Kuhn commented on patch set 2 CR -1 02/14/22, 21:28
not sure. at least need slightly more info, i guess.DefaultJavaScriptAssetTrait.php:60sure here? this means method now returns 'true' if TSFE is sot set.TypoScriptFrontendController.php:1712sure? ArrayUtility::mergeRecursiveWithOverrule() has this odd '__unset' behavior.TypoScriptFrontendController.php:1717same question here. -
Benni Mack commented on patch set 2 02/14/22, 22:06
TypoScriptFrontendController.php:1712ReplyI think for TypoScript, people use config.myOption > as this is the one documented.TypoScriptFrontendController.php:1717ReplyI think people should use "config.myOption >" instead. -
Benni Mack commented on patch set 2 02/14/22, 22:08
DefaultJavaScriptAssetTrait.php:60ReplyThen it should be $frontendController?->config otherwise it should fatal. -
Christian Kuhn commented on patch set 2 02/15/22, 09:08
TypoScriptFrontendController.php:1712ReplyAckTypoScriptFrontendController.php:1717ReplyAck -
Benni Mack uploaded patch set 3 02/15/22, 15:09
-
Benni Mack commented on patch set 3 02/15/22, 15:09
solved your remarksDefaultJavaScriptAssetTrait.php:60ReplyDone -
core-ci voted on patch set 3 V +1 02/15/22, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23632
-
Stefan Bürk voted on patch set 3 V +1 CR +1 02/18/22, 00:49
-
Christian Kuhn voted on patch set 3 V +2 CR +2 02/18/22, 08:35
-
Christian Kuhn merged patch set 4 02/18/22, 08:35