73488[!!!][FEATURE] Auto-registration of NewContentElementWizard via TCA
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 20
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php12+164 −22
- typo3/sysext/backend/Configuration/page.tsconfig+0 −16
- typo3/sysext/backend/Resources/Private/Language/locallang_db_new_content_el.xlf+3 −1
- typo3/sysext/backend/Tests/Unit/Controller/ContentElement/NewContentElementControllerTest.phpnew+175 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102834-RemoveItemsFromNewContentElementWizard.rstnew+48 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102834-Auto-registrationOfNewContentElementWizardViaTCA.rst6new+164 −0
- typo3/sysext/core/Resources/Private/Language/Form/locallang_tabs.xlf+21 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/FalMetadataCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlineContentElementLocalizeSynchronizeCest.php+1 −1
- typo3/sysext/felogin/Configuration/TCA/Overrides/tt_content.php+1 −1
- typo3/sysext/felogin/Configuration/page.tsconfigdeleted+0 −13
- typo3/sysext/form/Configuration/TCA/Overrides/tt_content.php+1 −1
- typo3/sysext/form/Configuration/page.tsconfigdeleted+0 −13
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+114 −94
- typo3/sysext/frontend/Configuration/page.tsconfig+0 −210
- typo3/sysext/frontend/Resources/Private/Language/Database.xlf+3 −1
- typo3/sysext/frontend/Resources/Private/Language/locallang_ttc.xlf+254 −310
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsByUpdateWithDiff.php+2 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsWithDiff.php+2 −2
- typo3/sysext/indexed_search/Configuration/page.tsconfigdeleted+0 −13
Review log 4061
Show 2236 earlier messages
-
Benni Mack uploaded patch set 1 02/14/22, 19:43
-
core-ci voted on patch set 1 V -1 02/14/22, 19:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23555
-
Simon Schaufelberger uploaded patch set 2 08/03/22, 23:28
-
core-ci voted on patch set 2 V -1 08/03/22, 23:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29812
-
Benni Mack marked it work in progress 03/24/23, 11:45
-
Nikita Hovratov uploaded patch set 3
V -107/20/23, 16:31 -
core-ci voted on patch set 3 V -1 07/20/23, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44358
-
Nikita Hovratov uploaded patch set 4
V -107/21/23, 08:31 -
core-ci voted on patch set 4 V -1 07/21/23, 08:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44368
-
Nikita Hovratov uploaded patch set 5
V -111/23/23, 22:53 -
Nikita Hovratov marked it ready for review 11/23/23, 22:53
-
core-ci voted on patch set 5 V -1 11/23/23, 23:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49826
-
Nikita Hovratov uploaded patch set 6
V -111/24/23, 00:27 -
core-ci voted on patch set 6 V -1 11/24/23, 00:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49827
-
Nikita Hovratov uploaded patch set 7
V -111/24/23, 01:15 -
core-ci voted on patch set 7 V -1 11/24/23, 01:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49829
-
Benni Mack uploaded patch set 8
V -101/12/24, 11:24 -
Benni Mack uploaded patch set 9 01/12/24, 11:26
-
core-ci voted on patch set 8 V -1 01/12/24, 11:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51495
-
core-ci voted on patch set 9 V -1 01/12/24, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51496
-
Nikita Hovratov uploaded patch set 10
V -101/14/24, 17:06 -
core-ci voted on patch set 10 V -1 01/14/24, 17:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51555
-
Nikita Hovratov uploaded patch set 11
V -101/14/24, 17:32 -
core-ci voted on patch set 11 V -1 01/14/24, 17:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51556
-
Nikita Hovratov uploaded patch set 12
V -101/14/24, 19:01 -
core-ci voted on patch set 12 V +1 01/14/24, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51557
-
Nikita Hovratov uploaded patch set 13
V +101/14/24, 19:25 -
core-ci voted on patch set 13 V +1 01/14/24, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51559
-
Chris Müller commented on patch set 13 01/14/24, 20:30
I think we need a Breaking rst as the "show" option is not evaluated anymore. -
Oli Bartsch commented on patch set 13 V -1 01/15/24, 17:44
NewContentElementController.php:253This currently triggers a array to string conversion in case a plugin subtype with a new group, not present in an itemsGroup is added. However the reason seems to be unrelated to this patch but was introduced with #102826. Seems to be a bug in this block https://github.com/TYPO3/typo3/blob/main/typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php#L850NewContentElementController.php:289This needs a fallback since `$selectItem->getGroup()` might not be defined in `itemGroups`. To be in line with the select field, this should "just" use the identifier.NewContentElementController.php:307The corresponding `type` is missing here.NewContentElementController.php:320Let's please have a test for this, similar to TcaMigration. Currently this leads to all wizards from PageTs are being added to the final wizard array because ohne 'common.' is unset. This should however only return the items, merged from `common.` to `default.`. Therefore, this should be something like: ``` if (!array_key_exists('common.', $wizardsFromPageTs)) { return []; } return [ 'default.' => array_merge($wizardsFromPageTs['default.'] ?? [], $wizardsFromPageTs['common.']) ]; ```Feature-102834-Auto-registrationOfNewContentElementWizardViaTCA.rst:84Could we please adjust this example to also take `tt_content_defValues` into account, especially because this must be configured using the dot notating (which we might want to improve?).Feature-102834-Auto-registrationOfNewContentElementWizardViaTCA.rst:110This does not work as `mod.wizards.newContentElement.wizardItems` is no longer evaluated, except the migration from common to default. -
Oli Bartsch commented on patch set 13 01/15/24, 23:32
NewContentElementController.php:253Reply -
Nikita Hovratov commented on patch set 13 01/16/24, 12:11
NewContentElementController.php:253ReplyDone -
Oli Bartsch commented on patch set 13 01/16/24, 12:40
on it -
Oli Bartsch uploaded patch set 14
V +101/17/24, 12:42 -
core-ci voted on patch set 14 V -1 01/17/24, 12:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51682
-
Oli Bartsch uploaded patch set 15
V -101/17/24, 12:50
-
core-ci voted on patch set 15 V +1 01/17/24, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51683
-
Oli Bartsch commented on patch set 15 01/17/24, 13:59
Reply
DoneNewContentElementController.php:289ReplyDoneNewContentElementController.php:307ReplyDoneNewContentElementController.php:320ReplyDoneFeature-102834-Auto-registrationOfNewContentElementWizardViaTCA.rst:84ReplyDoneFeature-102834-Auto-registrationOfNewContentElementWizardViaTCA.rst:110ReplyDone -
Benni Mack commented on patch set 15 CR -2 01/17/24, 15:03
let me check something -
Andreas Kienast commented on patch set 15 01/22/24, 14:57
Reply
Did you have time to check something? ;) -
Benni Mack uploaded patch set 16
V +101/22/24, 20:57Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 16 V +1 01/22/24, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51947
-
Benni Mack uploaded patch set 17
V +101/22/24, 21:13Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benni Mack voted on patch set 17 CR 0 01/22/24, 21:13
-
Benni Mack uploaded patch set 18 01/22/24, 21:15
-
Benni Mack commented on patch set 18 01/22/24, 21:16
Ready from my side. I am happy now -
core-ci voted on patch set 17 V -1 01/22/24, 21:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51948
-
core-ci voted on patch set 18 V -1 01/22/24, 21:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51949
-
Benni Mack uploaded patch set 19
V -101/22/24, 21:43 -
core-ci voted on patch set 19 V -1 01/22/24, 21:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51954
-
Benni Mack uploaded patch set 20
V -101/22/24, 21:53 -
core-ci voted on patch set 20 V +1 01/22/24, 22:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51955
-
Benni Mack voted on patch set 20 CR +1 V +1 01/22/24, 22:37
-
Andreas Kienast commented on patch set 20 01/23/24, 07:08
NewContentElementController.php:265Should we add a safe-guard in case a "smart" developer tinkers with tt_content TCA and removes `type` and/or `subtype_value_field`?Feature-102834-Auto-registrationOfNewContentElementWizardViaTCA.rst:21as follows -
Oli Bartsch commented on patch set 20 CR -1 01/23/24, 07:26
will review again -
Oli Bartsch uploaded patch set 21
CR +1V +101/23/24, 08:34 -
Oli Bartsch commented on patch set 21 CR +1 V +1 01/23/24, 08:34
NewContentElementController.php:265ReplyDoneFeature-102834-Auto-registrationOfNewContentElementWizardViaTCA.rst:21ReplyDone -
Andreas Kienast voted on patch set 21 CR +1 V +1 01/23/24, 08:39
-
core-ci voted on patch set 21 V +1 01/23/24, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51969
-
Benni Mack commented on patch set 21 CR +2 V +2 01/23/24, 08:57
NewContentElementController.php:274IMHO this is not increasing readability. -
Benni Mack merged patch set 22 01/23/24, 08:57