Review TYPO3_4-6 Merged

7349[BUGFIX] ENABLE_INSTALL_TOOL does not respect fileCreateMask

Markus Klein CR +2 V +2 Easy +4 −1 updated 06/03/13, 20:49

Commit message

When this file is created by the Install tool, the fileCreateMask
is not respected. That does not allow to delete this file through
FTP or from SSH if the web server user and group is different
from logged in user.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Stefan Neufeind +1
    • Mario Rimann +1
    • Markus Klein +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Markus Klein +1

Issues 1

Files 1

Review log 6

  1. Tolleiv Nietsch commented on patch set 1 V 0 01/17/12, 10:17

    by team member; Looks good to me, approved
  2. Mario Rimann commented on patch set 1 01/17/12, 10:17

    Looks good to me, but someone else must approve
  3. Stefan Neufeind commented on patch set 1 01/17/12, 10:17

    Looks good to me, but someone else must approve same as in master, fine by reading
  4. Markus Klein voted on patch set 1 V 0 01/17/12, 10:17

  5. Markus Klein commented on patch set 1 01/17/12, 10:17

    Looks good to me, but someone else must approve
  6. Steffen Ritter merged patch set 1 01/17/12, 10:17