Review main Merged

73491[TASK] Cleanup code of ext:sys_note

Georg Ringer CR +2 V +2 Easy +8 −20 updated 02/17/22, 23:21

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1014

  1. Georg Ringer uploaded patch set 1 02/14/22, 20:09

  2. Georg Ringer commented on patch set 1 02/14/22, 20:09

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 02/14/22, 20:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23560

  4. Chris Müller commented on patch set 1 02/14/22, 20:37

    NoteVisibleFieldsTest.php:29

    The annotation can then be removed (or use "@var list<string>")
  5. Georg Ringer rebased onto patch set 2 02/15/22, 07:40

  6. core-ci voted on patch set 2 V +1 02/15/22, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23588

  7. Nikita Hovratov commented on patch set 2 02/15/22, 08:12

    NoteVisibleFieldsTest.php:29 Reply

    I think we mostly use "string[]" for this (same thing).
  8. Benni Mack commented on patch set 3 02/16/22, 22:24

    Published edit on patch set 2.
  9. core-ci voted on patch set 3 V +1 02/16/22, 22:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23760

  10. Benni Mack uploaded patch set 4 02/17/22, 22:37

  11. core-ci voted on patch set 4 V +1 02/17/22, 22:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23841

  12. Benni Mack commented on patch set 4 V +1 CR +1 02/17/22, 23:18

    NoteVisibleFieldsTest.php:29 Reply

    Done
  13. Oli Bartsch voted on patch set 4 V +2 CR +2 02/17/22, 23:21

  14. Oli Bartsch merged patch set 5 02/17/22, 23:21