Review main Merged Breaking

73492[!!!][TASK] Require PHP mbstring and intl extensions

Christian Kuhn CR +2 V +2 Normal +95 −136 updated 02/14/22, 20:59

Commit message

* mbstring: This is one of the most common extensions,
  often compiled directly into default packages, or
  available as additional package. While the symfony
  polyfill package adds the most common functions, it
  is not complete and we're already working around
  possible non-existance in a couple of places. The
  native functions are quicker and it should be
  fair to require mbstring in a modern PHP 8.1 build.

* intl: We really need this package to finally solve
  various sorting and date issues in the system. The
  symfony polyfills are partially stubs only that
  implement only a small set of features for
  english-only. This extension is the only way to
  finally drop dependencies to the nasty locales,
  which is a far bigger burden on systems than
  requiring intl.

$ composer req ext-mbstring
$ composer req ext-mbstring -d typo3/sysext/core --no-update
$ composer req ext-intl
$ composer req ext-intl -d typo3/sysext/core --no-update
$ composer rem symfony/polyfill-mbstring
$ composer rem symfony/polyfill-mbstring -d typo3/sysext/core --no-update
$ composer rem symfony/polyfill-mbstring -d typo3/sysext/frontend --no-update
$ composer rem symfony/polyfill-intl-icu
$ composer rem symfony/polyfill-intl-icu -d typo3/sysext/core --no-update
$ composer rem symfony/polyfill-intl-idn
$ composer rem symfony/polyfill-intl-idn -d typo3/sysext/core --no-update
$ composer rem symfony/polyfill-intl-normalizer
$ composer rem symfony/polyfill-intl-normalizer -d typo3/sysext/core --no-update

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 911

  1. Christian Kuhn uploaded patch set 1 02/14/22, 20:21

  2. Benni Mack commented on patch set 1 02/14/22, 20:27

    Breaking-96889-RequirePHPMbstringAndIntl.rst:40

    "in the PHP".... can you quickly write down how to install these extensions in Ubuntu/Debian? Should be 3 lines of docs.

    Indexer.php:1049

    why not use mb_strcut here then? The comment was actually useful :D
  3. Christian Kuhn uploaded patch set 2 02/14/22, 20:30

  4. Christian Kuhn commented on patch set 2 02/14/22, 20:30

    Breaking-96889-RequirePHPMbstringAndIntl.rst:40 Reply

    Done

    Indexer.php:1049 Reply

    Done
  5. core-ci voted on patch set 1 V +1 02/14/22, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23561

  6. core-ci voted on patch set 2 V +1 02/14/22, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23563

  7. Benni Mack voted on patch set 2 V +1 CR +1 02/14/22, 20:41

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 02/14/22, 20:42

  9. Georg Ringer voted on patch set 2 CR +1 02/14/22, 20:49

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 02/14/22, 20:59

  11. Christian Kuhn merged patch set 3 02/14/22, 20:59