73492[!!!][TASK] Require PHP mbstring and intl extensions
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96889-RequirePHPMbstringAndIntl.rst2new+49 −0
- typo3/sysext/core/composer.json+2 −5
- typo3/sysext/frontend/composer.json+0 −1
- typo3/sysext/indexed_search/Classes/Indexer.php2+3 −5
- typo3/sysext/install/Classes/SystemEnvironment/Check.php+2 −1
- composer.json+2 −5
- composer.lock+37 −119
Review log 911
-
Christian Kuhn uploaded patch set 1 02/14/22, 20:21
-
Benni Mack commented on patch set 1 02/14/22, 20:27
Indexer.php:1049why not use mb_strcut here then? The comment was actually useful :D -
Christian Kuhn uploaded patch set 2 02/14/22, 20:30
-
Christian Kuhn commented on patch set 2 02/14/22, 20:30
Breaking-96889-RequirePHPMbstringAndIntl.rst:40ReplyDoneIndexer.php:1049ReplyDone -
core-ci voted on patch set 1 V +1 02/14/22, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23561
-
core-ci voted on patch set 2 V +1 02/14/22, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23563
-
Benni Mack voted on patch set 2 V +1 CR +1 02/14/22, 20:41
-
Stefan Bürk voted on patch set 2 V +1 CR +1 02/14/22, 20:42
-
Georg Ringer voted on patch set 2 CR +1 02/14/22, 20:49
-
Christian Kuhn voted on patch set 2 V +2 CR +2 02/14/22, 20:59
-
Christian Kuhn merged patch set 3 02/14/22, 20:59
Breaking-96889-RequirePHPMbstringAndIntl.rst:40