Review main Merged

73493[BUGFIX] Render workspace selection again in log module

Georg Ringer CR +2 V +2 Easy +10 −10 updated 02/14/22, 20:58

Commit message

During the rework of #96745 the fluid variable `showWorkspaceSelector`
was set too late to be used in the view.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 910

  1. Georg Ringer uploaded patch set 1 02/14/22, 20:33

  2. Georg Ringer commented on patch set 1 02/14/22, 20:33

    This change is ready for review.
  3. Oli Bartsch commented on patch set 1 02/14/22, 20:44

    BackendLogController.php:97

    What do you think about not introducing single use variable but just calling the method in the array assignment directly (like done for the other properties)?
  4. core-ci voted on patch set 1 V +1 02/14/22, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23565

  5. Georg Ringer commented on patch set 1 02/14/22, 20:48

    BackendLogController.php:97 Reply

    $constraint is modified and handed to the logEntryRepository + later used in the $assigns array, so it is a bit different
  6. Oli Bartsch commented on patch set 1 02/14/22, 20:51

    BackendLogController.php:97 Reply

    Ack
  7. Christian Kuhn voted on patch set 1 V +1 CR +1 02/14/22, 20:52

  8. Benni Mack voted on patch set 1 V +2 CR +2 02/14/22, 20:58

  9. Benni Mack merged patch set 2 02/14/22, 20:58

  10. Stefan Bürk voted on patch set 1 V +1 CR +1 02/14/22, 20:58