Review main Merged

73496[TASK] Simplify Controller in Info module

Benni Mack CR +2 V +2 Normal +25 −128 updated 02/14/22, 22:29

Commit message

This change is a pre-patch for introducing
https://review.typo3.org/c/Packages/TYPO3.CMS/+/73339

to allow to reduce the calls to $pObj
by using inheritance for all controllers
related to TypoScript parsing in "Web > Info"

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 79

  1. Benni Mack uploaded patch set 1 02/14/22, 21:58

  2. Christian Kuhn commented on patch set 1 CR -1 02/14/22, 22:07

    on it.

    InfoPageTyposcriptConfigController.php:51

    using $this here (see next file).

    PageInformationController.php:70

    using parent:: here ?!
  3. Christian Kuhn uploaded patch set 2 02/14/22, 22:09

  4. Christian Kuhn commented on patch set 2 02/14/22, 22:11

    InfoPageTyposcriptConfigController.php:51 Reply

    Done

    PageInformationController.php:70 Reply

    Done
  5. core-ci voted on patch set 1 V +1 02/14/22, 22:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23573

  6. core-ci voted on patch set 2 V +1 02/14/22, 22:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23576

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 02/14/22, 22:28

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 02/14/22, 22:29

  9. Christian Kuhn merged patch set 3 02/14/22, 22:29