73496[TASK] Simplify Controller in Info module
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+13 −30
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php2+5 −35
- typo3/sysext/info/Classes/Controller/PageInformationController.php2+2 −29
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+2 −31
- typo3/sysext/info/Configuration/Services.yaml+3 −3
Review log 79
-
Benni Mack uploaded patch set 1 02/14/22, 21:58
-
Christian Kuhn commented on patch set 1 CR -1 02/14/22, 22:07
on it.InfoPageTyposcriptConfigController.php:51using $this here (see next file).PageInformationController.php:70using parent:: here ?! -
Christian Kuhn uploaded patch set 2 02/14/22, 22:09
-
Christian Kuhn commented on patch set 2 02/14/22, 22:11
InfoPageTyposcriptConfigController.php:51ReplyDonePageInformationController.php:70ReplyDone -
core-ci voted on patch set 1 V +1 02/14/22, 22:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23573
-
core-ci voted on patch set 2 V +1 02/14/22, 22:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23576
-
Stefan Bürk voted on patch set 2 V +1 CR +1 02/14/22, 22:28
-
Christian Kuhn voted on patch set 2 V +2 CR +2 02/14/22, 22:29
-
Christian Kuhn merged patch set 3 02/14/22, 22:29