Review main Merged

73497[TASK] Simplify workspace handling in EXT:belog

Georg Ringer CR +2 V +2 Normal +12 −171 updated 02/15/22, 05:42

Commit message

Remove the overhead of using extbase to get all workspace records
and fetch them directly.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1519

  1. Georg Ringer uploaded patch set 1 02/14/22, 22:09

  2. Georg Ringer commented on patch set 1 02/14/22, 22:09

    This change is ready for review.
  3. Christian Kuhn commented on patch set 1 02/14/22, 22:13

    BackendLogController.php:47

    switch to protected readonly while you're changing inject anyway (see below).

    BackendLogController.php:278

    inject ConnectionPool.
  4. core-ci voted on patch set 1 V +1 02/14/22, 22:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23577

  5. Georg Ringer commented on patch set 1 02/14/22, 22:36

    One at a time pls
  6. Christian Kuhn uploaded patch set 2 02/14/22, 22:40

  7. Christian Kuhn commented on patch set 2 02/14/22, 22:40

    BackendLogController.php:47 Reply

    there is no point in not doing it now. pushed.

    BackendLogController.php:278 Reply

    Done
  8. Stefan Bürk commented on patch set 2 02/14/22, 22:42

    BackendLogController.php:276

    executeQuery()
  9. Christian Kuhn uploaded patch set 3 02/14/22, 22:43

  10. Christian Kuhn commented on patch set 3 02/14/22, 22:43

    BackendLogController.php:276 Reply

    Done
  11. Stefan Bürk commented on patch set 3 CR -1 02/14/22, 22:48

    on it
  12. core-ci voted on patch set 3 V +1 02/14/22, 22:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23579

  13. core-ci voted on patch set 2 V +1 02/14/22, 22:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23578

  14. Stefan Bürk uploaded patch set 4 02/14/22, 22:54

  15. core-ci voted on patch set 4 V +1 02/14/22, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23580

  16. Stefan Bürk voted on patch set 4 V +1 CR +1 02/14/22, 23:03

  17. Christian Kuhn voted on patch set 4 V +1 CR +1 02/14/22, 23:03

  18. Georg Ringer voted on patch set 4 V +2 CR +2 02/15/22, 05:42

  19. Georg Ringer merged patch set 5 02/15/22, 05:42