73497[TASK] Simplify workspace handling in EXT:belog
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/belog/Classes/Controller/BackendLogController.php6+10 −15
- typo3/sysext/belog/Classes/Domain/Model/Constraint.php+1 −1
- typo3/sysext/belog/Classes/Domain/Model/Workspace.phpdeleted+0 −64
- typo3/sysext/belog/Classes/Domain/Repository/LogEntryRepository.php+1 −1
- typo3/sysext/belog/Classes/Domain/Repository/WorkspaceRepository.phpdeleted+0 −47
- typo3/sysext/belog/Configuration/Extbase/Persistence/Classes.php+0 −3
- typo3/sysext/belog/Tests/Unit/Domain/Repository/WorkspaceRepositoryTest.phpdeleted+0 −40
Review log 1519
-
Georg Ringer uploaded patch set 1 02/14/22, 22:09
-
Georg Ringer commented on patch set 1 02/14/22, 22:09
This change is ready for review. -
Christian Kuhn commented on patch set 1 02/14/22, 22:13
BackendLogController.php:47switch to protected readonly while you're changing inject anyway (see below).BackendLogController.php:278inject ConnectionPool. -
core-ci voted on patch set 1 V +1 02/14/22, 22:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23577
-
Georg Ringer commented on patch set 1 02/14/22, 22:36
One at a time pls -
Christian Kuhn uploaded patch set 2 02/14/22, 22:40
-
Christian Kuhn commented on patch set 2 02/14/22, 22:40
BackendLogController.php:47Replythere is no point in not doing it now. pushed.BackendLogController.php:278ReplyDone -
Stefan Bürk commented on patch set 2 02/14/22, 22:42
BackendLogController.php:276executeQuery() -
Christian Kuhn uploaded patch set 3 02/14/22, 22:43
-
Christian Kuhn commented on patch set 3 02/14/22, 22:43
BackendLogController.php:276ReplyDone -
Stefan Bürk commented on patch set 3 CR -1 02/14/22, 22:48
on it -
core-ci voted on patch set 3 V +1 02/14/22, 22:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23579
-
core-ci voted on patch set 2 V +1 02/14/22, 22:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23578
-
Stefan Bürk uploaded patch set 4 02/14/22, 22:54
-
core-ci voted on patch set 4 V +1 02/14/22, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23580
-
Stefan Bürk voted on patch set 4 V +1 CR +1 02/14/22, 23:03
-
Christian Kuhn voted on patch set 4 V +1 CR +1 02/14/22, 23:03
-
Georg Ringer voted on patch set 4 V +2 CR +2 02/15/22, 05:42
-
Georg Ringer merged patch set 5 02/15/22, 05:42