73516[TASK] Upgrade enshrined/svg-sanitize to ^0.15.4
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
-
Verified V +2 Done
- Oliver Hader +2
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/entity.svg+1 −1
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/entity_2.svg+1 −1
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/svgOne.svg+0 −1
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/xlinkLoop.svg+0 −3
- typo3/sysext/core/composer.json+1 −1
- composer.json+1 −1
- composer.lock+7 −8
Review log 1519
-
Oliver Hader uploaded patch set 1 02/15/22, 09:41
-
Mathias Brodala commented on patch set 1 02/15/22, 09:44
We do not need to wait for https://github.com/darylldoyle/svg-sanitizer/pull/72 to be included, correct? -
core-ci voted on patch set 1 V -1 02/15/22, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23606
-
Oliver Hader marked it work in progress 02/15/22, 10:12
-
Oliver Hader commented on patch set 1 02/15/22, 10:13
Reply
Yes, we should wait... This change should have been WIP in the 1st place. I just wanted to see, whether there are tests that would fail... -
Mathias Brodala commented on patch set 1 02/15/22, 10:15
Reply
Ack -
Oliver Hader uploaded patch set 2 02/21/22, 09:51
-
Oliver Hader marked it ready for review 02/21/22, 09:54
-
core-ci voted on patch set 2 V +1 02/21/22, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23970
-
Markus Klein commented on patch set 2 02/21/22, 10:56
Can/should we rather go with `>=0.15.4 <1.0.0` to avoid the breakage with roave/... in the future. (`^` only allows 0.15.x now) -
Oliver Hader commented on patch set 2 02/21/22, 11:37
Reply
Fine for roave... but that also means, that basically a new `0.16` would be fetched automatically in a Composer scenario. At least, it gives freedom to TYPO3 projects, to use any version the wanna use (in the `0.x` scope) -
Oliver Hader uploaded patch set 3 02/21/22, 11:42
-
Markus Klein commented on patch set 3 02/21/22, 11:51
Thanks -
core-ci voted on patch set 3 V +1 02/21/22, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23980
-
Oliver Hader uploaded patch set 4 02/21/22, 13:14
-
Oliver Hader commented on patch set 4 02/21/22, 13:15
Briefly discussed at https://typo3.slack.com/archives/C03AM9R17/p1645444685705069 - sticking to `^0.15.4` - no "magic" -
core-ci voted on patch set 4 V +1 02/21/22, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23987
-
Oliver Hader voted on patch set 4 V +2 CR +2 02/21/22, 13:31
-
Oliver Hader merged patch set 5 02/21/22, 13:33