Review main Merged

73516[TASK] Upgrade enshrined/svg-sanitize to ^0.15.4

Oliver Hader CR +2 V +2 Easy +11 −16 updated 02/21/22, 13:33

Commit message

Recent release of enshrined/svg-sanitize addressed a XSS vulnerability.

The main purpose of having this library in TYPO3 is to protect against
user submitted images that contains markup - which is possible with
SVG files. In most TYPO3 scenarios these files would be stored in
https://example.org/fileadmin/evil.svg and can be fetched directly.

However, recent update for CVE-2022-23638 of the svg-sanitizer library
seems to address the usage of inline SVG, used in an embedded HTML
context, see https://github.com/darylldoyle/svg-sanitizer/issues/71

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 1519

  1. Oliver Hader uploaded patch set 1 02/15/22, 09:41

  2. Mathias Brodala commented on patch set 1 02/15/22, 09:44

    We do not need to wait for https://github.com/darylldoyle/svg-sanitizer/pull/72 to be included, correct?
  3. core-ci voted on patch set 1 V -1 02/15/22, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23606

  4. Oliver Hader marked it work in progress 02/15/22, 10:12

  5. Oliver Hader commented on patch set 1 02/15/22, 10:13

    Reply

    Yes, we should wait... This change should have been WIP in the 1st place. I just wanted to see, whether there are tests that would fail...
  6. Mathias Brodala commented on patch set 1 02/15/22, 10:15

    Reply

    Ack
  7. Oliver Hader uploaded patch set 2 02/21/22, 09:51

  8. Oliver Hader marked it ready for review 02/21/22, 09:54

  9. core-ci voted on patch set 2 V +1 02/21/22, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23970

  10. Markus Klein commented on patch set 2 02/21/22, 10:56

    Can/should we rather go with `>=0.15.4 <1.0.0` to avoid the breakage with roave/... in the future. (`^` only allows 0.15.x now)
  11. Oliver Hader commented on patch set 2 02/21/22, 11:37

    Reply

    Fine for roave... but that also means, that basically a new `0.16` would be fetched automatically in a Composer scenario. At least, it gives freedom to TYPO3 projects, to use any version the wanna use (in the `0.x` scope)
  12. Oliver Hader uploaded patch set 3 02/21/22, 11:42

  13. Markus Klein commented on patch set 3 02/21/22, 11:51

    Thanks
  14. core-ci voted on patch set 3 V +1 02/21/22, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23980

  15. Oliver Hader uploaded patch set 4 02/21/22, 13:14

  16. Oliver Hader commented on patch set 4 02/21/22, 13:15

    Briefly discussed at https://typo3.slack.com/archives/C03AM9R17/p1645444685705069 - sticking to `^0.15.4` - no "magic"
  17. core-ci voted on patch set 4 V +1 02/21/22, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23987

  18. Oliver Hader voted on patch set 4 V +2 CR +2 02/21/22, 13:31

  19. Oliver Hader merged patch set 5 02/21/22, 13:33