73517[TASK] Deprecate old ModuleTemplate API
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Stefan Bürk +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 4
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php2+47 −13
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-96903-DeprecateOldModuleTemplateAPI.rst2new+66 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96812-OverrideBackendTemplatesWithTSconfig.rst+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php4+35 −0
Review log 1317
-
Christian Kuhn uploaded patch set 1 02/15/22, 10:44
-
core-ci voted on patch set 1 V +1 02/15/22, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23610
-
Benni Mack commented on patch set 1 02/15/22, 11:03
-
Christian Kuhn commented on patch set 1 02/15/22, 11:37
MethodCallMatcher.php:5172Reply"Methods :php:`setContent()`, :php:`header()` and :php:`getView()` are rather common names, the extension scanner is not configured to scan for them. All other methods names are scanned, the extension scanner will report possible usages as weak match." -
Christian Kuhn uploaded patch set 2 02/15/22, 11:51
-
Christian Kuhn commented on patch set 2 02/15/22, 11:52
MethodCallMatcher.php:5172Replysetting to resolved for now. we *could* add the three missing scanner entries as well, but i fear they'll add quite a bit of noise to extensions. -
Oli Bartsch commented on patch set 1 02/15/22, 11:54
ModuleTemplate.php:215The two consecutive adjectives sound odd in this sentence.Deprecation-96903-DeprecateOldModuleTemplateAPI.rst:38I think this was mostly used to enable editing of the page title (by setting the "t3js-title-inlineedit" class). We should somehow mention this here. -
core-ci voted on patch set 2 V +1 02/15/22, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23617
-
Benni Mack commented on patch set 2 02/16/22, 06:55
MethodCallMatcher.php:5172Replythx for the explanation! -
Christian Kuhn commented on patch set 2 02/16/22, 09:05
ModuleTemplate.php:215ReplyDoneDeprecation-96903-DeprecateOldModuleTemplateAPI.rst:38ReplyDone -
Christian Kuhn uploaded patch set 3 02/16/22, 09:05
-
core-ci voted on patch set 3 V +1 02/16/22, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23705
-
Christian Kuhn uploaded patch set 4 02/16/22, 13:36
-
core-ci voted on patch set 4 V +1 02/16/22, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23722
-
Stefan Bürk voted on patch set 4 V +1 CR +1 02/16/22, 14:02
-
Anja Leichsenring voted on patch set 4 V +2 CR +2 02/16/22, 14:43
-
Anja Leichsenring merged patch set 5 02/16/22, 14:43
MethodCallMatcher.php:5172