Review main Merged

73517[TASK] Deprecate old ModuleTemplate API

Christian Kuhn CR +2 V +2 Normal +149 −14 updated 02/16/22, 14:43

Commit message

With the introduction of the simplified ModuleTemplate
API and the transition of all core backend modules
towards it, the old API can and should be deprecated
to faciliate the "Override templates with TsConfig"
feature in extensions as well.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 1317

  1. Christian Kuhn uploaded patch set 1 02/15/22, 10:44

  2. core-ci voted on patch set 1 V +1 02/15/22, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23610

  3. Benni Mack commented on patch set 1 02/15/22, 11:03

    MethodCallMatcher.php:5172

    Isn't "getView" missing?
  4. Christian Kuhn commented on patch set 1 02/15/22, 11:37

    MethodCallMatcher.php:5172 Reply

    "Methods :php:`setContent()`, :php:`header()` and :php:`getView()` are rather common names, the extension scanner is not configured to scan for them. All other methods names are scanned, the extension scanner will report possible usages as weak match."
  5. Christian Kuhn uploaded patch set 2 02/15/22, 11:51

  6. Christian Kuhn commented on patch set 2 02/15/22, 11:52

    MethodCallMatcher.php:5172 Reply

    setting to resolved for now. we *could* add the three missing scanner entries as well, but i fear they'll add quite a bit of noise to extensions.
  7. Oli Bartsch commented on patch set 1 02/15/22, 11:54

    ModuleTemplate.php:215

    The two consecutive adjectives sound odd in this sentence.

    Deprecation-96903-DeprecateOldModuleTemplateAPI.rst:38

    I think this was mostly used to enable editing of the page title (by setting the "t3js-title-inlineedit" class). We should somehow mention this here.
  8. core-ci voted on patch set 2 V +1 02/15/22, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23617

  9. Benni Mack commented on patch set 2 02/16/22, 06:55

    MethodCallMatcher.php:5172 Reply

    thx for the explanation!
  10. Christian Kuhn commented on patch set 2 02/16/22, 09:05

    ModuleTemplate.php:215 Reply

    Done

    Deprecation-96903-DeprecateOldModuleTemplateAPI.rst:38 Reply

    Done
  11. Christian Kuhn uploaded patch set 3 02/16/22, 09:05

  12. core-ci voted on patch set 3 V +1 02/16/22, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23705

  13. Christian Kuhn uploaded patch set 4 02/16/22, 13:36

  14. core-ci voted on patch set 4 V +1 02/16/22, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23722

  15. Stefan Bürk voted on patch set 4 V +1 CR +1 02/16/22, 14:02

  16. Anja Leichsenring voted on patch set 4 V +2 CR +2 02/16/22, 14:43

  17. Anja Leichsenring merged patch set 5 02/16/22, 14:43