73518[!!!][FEATURE] Avoid BackendTemplateView
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 74
- Build/phpstan/phpstan-baseline.neon+0 −40
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ClearCacheToolbarItem.php2+15 −15
- typo3/sysext/backend/Classes/Backend/ToolbarItems/HelpToolbarItem.php+17 −15
- typo3/sysext/backend/Classes/Backend/ToolbarItems/LiveSearchToolbarItem.php2+15 −6
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php+17 −17
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php+17 −23
- typo3/sysext/backend/Classes/Backend/ToolbarItems/UserToolbarItem.php+16 −12
- typo3/sysext/backend/Classes/Controller/Wizard/ImageManipulationController.php+5 −9
- typo3/sysext/backend/Classes/Controller/BackendController.php+9 −7
- typo3/sysext/backend/Classes/Controller/ColumnSelectorController.php+7 −9
- typo3/sysext/backend/Classes/Controller/MfaController.php+3 −4
- typo3/sysext/backend/Classes/Controller/MfaSetupController.php+5 −6
- typo3/sysext/backend/Classes/Controller/ResetPasswordController.php+5 −7
- typo3/sysext/backend/Classes/Controller/ShortcutController.php+7 −15
- typo3/sysext/backend/Classes/Controller/SystemInformationController.php+3 −1
- typo3/sysext/backend/Classes/Form/Container/AbstractContainer.php+8 −4
- typo3/sysext/backend/Classes/Form/Container/OuterWrapContainer.php+7 −3
- typo3/sysext/backend/Classes/Form/Container/SiteLanguageContainer.php+7 −3
- typo3/sysext/backend/Classes/Form/Element/ImageManipulationElement.php+9 −4
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+5 −4
Show 54 more files
- typo3/sysext/backend/Classes/Toolbar/RequestAwareToolbarItemInterface.php2new+29 −0
- typo3/sysext/backend/Configuration/Services.yaml+3 −0
- typo3/sysext/backend/Tests/Functional/Controller/MfaControllerTest.php+4 −0
- typo3/sysext/backend/Tests/Functional/Controller/MfaSetupControllerTest.php+5 −1
- typo3/sysext/backend/Tests/Functional/Controller/ResetPasswordControllerTest.php+4 −0
- typo3/sysext/backend/Tests/Functional/Controller/ShortcutControllerTest.php+4 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96904-ExtreportsReportsDoNotReceiveParentObject.rstnew+68 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96904-BackendToolbarItemsAreRequestAware.rstnew+31 −0
- typo3/sysext/fluid/Classes/View/BackendTemplateView.phpdeleted+0 −28
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+22 −5
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php+8 −3
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+9 −23
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+1 −5
- typo3/sysext/install/Classes/Controller/AbstractController.php3+12 −5
- typo3/sysext/install/Classes/Controller/InstallerController.php2+11 −5
- typo3/sysext/install/Classes/Controller/UpgradeController.php+3 −21
- typo3/sysext/install/Tests/Unit/Controller/UpgradeControllerTest.php+6 −4
- typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php+16 −19
- typo3/sysext/opendocs/Classes/Controller/OpenDocumentController.php+3 −2
- typo3/sysext/recordlist/Classes/Browser/AbstractElementBrowser.php+5 −5
- typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php+5 −3
- typo3/sysext/recordlist/Classes/Browser/FileBrowser.php+1 −1
- typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php+29 −21
- typo3/sysext/recordlist/Classes/Controller/RecordDownloadController.php+7 −8
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+4 −3
- typo3/sysext/recordlist/Classes/LinkHandler/AbstractLinkHandler.php+2 −5
- typo3/sysext/recordlist/Classes/LinkHandler/FileLinkHandler.php+2 −8
- typo3/sysext/recordlist/Classes/LinkHandler/MailLinkHandler.php+2 −7
- typo3/sysext/recordlist/Classes/LinkHandler/PageLinkHandler.php+2 −7
- typo3/sysext/recordlist/Classes/LinkHandler/RecordLinkHandler.php+1 −6
- typo3/sysext/recordlist/Classes/LinkHandler/TelephoneLinkHandler.php+1 −6
- typo3/sysext/recordlist/Classes/LinkHandler/UrlLinkHandler.php+1 −7
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+15 −19
- typo3/sysext/recordlist/Classes/View/RecordSearchBoxComponent.php+8 −5
- typo3/sysext/recordlist/Configuration/Services.yaml+4 −0
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php+5 −6
- typo3/sysext/recycler/Configuration/Services.yaml+3 −0
- typo3/sysext/redirects/Classes/Report/Status/RedirectStatus.php+12 −7
- typo3/sysext/redirects/Configuration/Services.yaml+3 −0
- typo3/sysext/reports/Classes/Controller/ReportController.php+1 −3
- typo3/sysext/reports/Classes/Report/Status/Status.php+19 −21
- typo3/sysext/reports/Configuration/Services.yaml+3 −0
- typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php+3 −3
- typo3/sysext/sys_note/Classes/Hook/InfoModuleHook.php+1 −1
- typo3/sysext/sys_note/Classes/Provider/PageModuleProvider.php+2 −2
- typo3/sysext/sys_note/Classes/Provider/RecordListProvider.php+2 −2
- typo3/sysext/sys_note/Classes/Renderer/NoteRenderer.php+10 −10
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerController.php+1 −3
- typo3/sysext/tstemplate/Classes/Controller/TyposcriptConstantEditorController.php+1 −4
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptObjectBrowserController.php+1 −4
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateInformationController.php+1 −4
- typo3/sysext/workspaces/Classes/Backend/ToolbarItems/WorkspaceSelectorToolbarItem.php+17 −17
- typo3/sysext/workspaces/Classes/Controller/Remote/ActionHandler.php+27 −29
- typo3/sysext/workspaces/Configuration/Services.yaml+3 −0
Review log 2029
Show 34 earlier messages
-
Christian Kuhn uploaded patch set 1 02/15/22, 11:46
-
core-ci voted on patch set 1 V +1 02/15/22, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23615
-
Oli Bartsch commented on patch set 1 02/15/22, 13:27
IMO this is a FEATURE, since new functionality is introduced, which allows to receive the PSR-7 Request in the toolbar items. Actually, I assume using the BackendViewFactory is also recommended for toolbar items of third party extensions, right? Therefore, the new interface will be mandatory.LiveSearchToolbarItem.php:35Why do we change the visibility to private? Is there a rule or guideline when to use private and when to use protected?RequestAwareToolbarItemInterface.php:26Like mentioned in my other comment, since this is public API, it should somehow be documented, e.g. in Feature.rst. Third party extensions will benefit from using this interface. -
Oli Bartsch commented on patch set 1 02/15/22, 13:49
ClearCacheToolbarItem.php:38Should we define this as nullable? This will otherwise lead to an exception, when accessing this (indirectly by calling a public method, using the $request), while setRequest() had not been called beforehand.
-
Christian Kuhn uploaded patch set 2 02/16/22, 11:25
-
Christian Kuhn commented on patch set 2 02/16/22, 11:26
decided to put *all* BackendTemplateView removals into this patch for now ... may split later again and will then take care of comments, too. -
core-ci voted on patch set 2 V -1 02/16/22, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23714
-
Christian Kuhn uploaded patch set 3 02/16/22, 13:22
-
Christian Kuhn uploaded patch set 4 02/16/22, 13:27
-
core-ci voted on patch set 3 V -1 02/16/22, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23720
-
core-ci voted on patch set 4 V -1 02/16/22, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23721
-
Christian Kuhn uploaded patch set 5 02/16/22, 14:59
-
Christian Kuhn commented on patch set 5 02/16/22, 15:03
Reply
DoneClearCacheToolbarItem.php:38ReplyNo. The toolbar item should very well assume that setRequest() is called when RequestAwareToolbarItemInterface is implemented. Otherwise, that is a fail in the calling core code and should fail.LiveSearchToolbarItem.php:35Replyno strict rule (yet). imho: these classes must not be xclassed / extended. they should actually be final. there is a registration to override with own classes if needed. so private for these 'leaf' classes really should be fine here. I was not totally sure here for the toolbar items, but I think it's fair enough to do it. If you insist on going back to protected, I'll do so, though.RequestAwareToolbarItemInterface.php:26Replywill document. -
core-ci voted on patch set 5 V -1 02/16/22, 15:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23730
-
Christian Kuhn uploaded patch set 6 02/16/22, 15:40
-
core-ci voted on patch set 6 V +1 02/16/22, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23732
-
Christian Kuhn uploaded patch set 7 02/16/22, 16:50
-
core-ci voted on patch set 7 V +1 02/16/22, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23737
-
Christian Kuhn uploaded patch set 8 02/16/22, 17:19
-
core-ci voted on patch set 8 V +1 02/16/22, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23738
-
Christian Kuhn updated the commit message in patch set 9 02/16/22, 17:31
-
core-ci voted on patch set 9 V +1 02/16/22, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23739
-
Stefan Bürk voted on patch set 9 V +1 CR +1 02/16/22, 19:06
-
Benjamin Franzke commented on patch set 9 CR +1 02/16/22, 19:22
thx! -
Benjamin Franzke commented on patch set 9 V +1 02/16/22, 19:51
AbstractController.php:45RenderingContextFactory could/should be injected. But not a blocker right now.InstallerController.php:1145RenderingContextFactory could/should be injected. But not a blocker right now. -
Christian Kuhn commented on patch set 9 02/16/22, 19:56
AbstractController.php:45ReplyAck. impossible in this case at the moment, since abstract should use inject* methods, but fail-safe container does not support this currently. may need a dedicated patch.InstallerController.php:1145ReplyAck. impossible in this case at the moment, since abstract should use inject* methods, but fail-safe container does not support this currently. may need a dedicated patch. -
Christian Kuhn voted on patch set 9 V +2 CR +2 02/16/22, 20:06
-
Christian Kuhn merged patch set 10 02/16/22, 20:06
-
Benjamin Franzke commented on patch set 10 02/16/22, 20:10
AbstractController.php:45ReplyNo, all installtool controllers are manually wired in install/ServiceProvider.php, therefore . Anyway, we can fix that later, and maybe rather introduce a View factory for the installtool instead (and drop AbstractController).