Review main Merged

73521[TASK] Add Module definiton to .phpstorm.meta.php

Oli Bartsch CR +2 V +2 Easy +6 −2 updated 02/15/22, 12:59

Commit message

Since #96797, the Module object is added to the
PSR-7 Request, in case a TYPO3 backend module
is requested.

To further support autocompletion, the Module
definition is now added to the .phpstorm.meta.php file.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Oli Bartsch uploaded patch set 1 02/15/22, 12:32

  2. Benni Mack voted on patch set 1 V +1 CR +1 02/15/22, 12:33

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 02/15/22, 12:39

  4. core-ci voted on patch set 1 V +1 02/15/22, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23620

  5. Oli Bartsch updated the commit message in patch set 2 02/15/22, 12:42

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 02/15/22, 12:42

  7. core-ci voted on patch set 2 V +1 02/15/22, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23621

  8. Benni Mack voted on patch set 2 V +2 CR +2 02/15/22, 12:59

  9. Benni Mack merged patch set 3 02/15/22, 12:59