Review main Merged

73523[TASK] Move LinkVars calculation into separate class

Benni Mack CR +2 V +2 Hard +382 −308 updated 02/15/22, 22:34

Commit message

The TSFE god object handles too many things. One
part is the calculation of config.linkVars which
is now moved into its own separate class.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1317

  1. Benni Mack uploaded patch set 1 02/15/22, 14:46

  2. core-ci voted on patch set 1 V -1 02/15/22, 14:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23628

  3. Benni Mack uploaded patch set 2 02/15/22, 15:05

  4. core-ci voted on patch set 2 V +1 02/15/22, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23630

  5. Stefan Bürk commented on patch set 2 02/15/22, 16:46

    LinkVarsCalculator.php:129

    Do we really need "int|string" here ? Usage in 'getAllowedLinkVarsFromRequest()' should always provide string for $value, from reading. If this is really needed, we need to add some string casts to avoid php errors if $value is a "int".
  6. Oli Bartsch uploaded patch set 3 02/15/22, 18:02

  7. core-ci voted on patch set 3 V +1 02/15/22, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23649

  8. Oli Bartsch uploaded patch set 4 02/15/22, 18:47

  9. Oli Bartsch commented on patch set 4 02/15/22, 18:49

    LinkVarsCalculator.php:129 Reply

    It seems that this change is related to failing tests in patchset 1. However, locally all tests passed, using just "string". So let's wait for CI.
  10. core-ci voted on patch set 4 V +1 02/15/22, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23652

  11. Stefan Bürk commented on patch set 4 02/15/22, 19:03

    LinkVarsCalculator.php:129 Reply

    I've read the errors in the pipeline error for patchset 1. So, you may be right, but I think it was solved at another place thus, making this union type here superflous again. Thanks for taking care to change this.
  12. Oli Bartsch commented on patch set 4 02/15/22, 19:04

    LinkVarsCalculator.php:129 Reply

    Yep looks fine now.
  13. Benni Mack commented on patch set 4 02/15/22, 20:33

    OK. fine by me then!
  14. Stefan Bürk voted on patch set 4 V +1 CR +1 02/15/22, 20:36

  15. Oli Bartsch voted on patch set 4 V +1 CR +1 02/15/22, 20:51

  16. Benni Mack voted on patch set 4 V +2 CR +2 02/15/22, 22:34

  17. Benni Mack merged patch set 5 02/15/22, 22:34