73523[TASK] Move LinkVars calculation into separate class
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+9 −136
- typo3/sysext/frontend/Classes/Typolink/LinkVarsCalculator.php4new+175 −0
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+0 −172
- typo3/sysext/frontend/Tests/Unit/Typolink/LinkVarsCalculatorTest.phpnew+198 −0
Review log 1317
-
Benni Mack uploaded patch set 1 02/15/22, 14:46
-
core-ci voted on patch set 1 V -1 02/15/22, 14:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23628
-
Benni Mack uploaded patch set 2 02/15/22, 15:05
-
core-ci voted on patch set 2 V +1 02/15/22, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23630
-
Stefan Bürk commented on patch set 2 02/15/22, 16:46
-
Oli Bartsch uploaded patch set 3 02/15/22, 18:02
-
core-ci voted on patch set 3 V +1 02/15/22, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23649
-
Oli Bartsch uploaded patch set 4 02/15/22, 18:47
-
Oli Bartsch commented on patch set 4 02/15/22, 18:49
LinkVarsCalculator.php:129ReplyIt seems that this change is related to failing tests in patchset 1. However, locally all tests passed, using just "string". So let's wait for CI. -
core-ci voted on patch set 4 V +1 02/15/22, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23652
-
Stefan Bürk commented on patch set 4 02/15/22, 19:03
LinkVarsCalculator.php:129ReplyI've read the errors in the pipeline error for patchset 1. So, you may be right, but I think it was solved at another place thus, making this union type here superflous again. Thanks for taking care to change this. -
Oli Bartsch commented on patch set 4 02/15/22, 19:04
LinkVarsCalculator.php:129ReplyYep looks fine now. -
Benni Mack commented on patch set 4 02/15/22, 20:33
OK. fine by me then! -
Stefan Bürk voted on patch set 4 V +1 CR +1 02/15/22, 20:36
-
Oli Bartsch voted on patch set 4 V +1 CR +1 02/15/22, 20:51
-
Benni Mack voted on patch set 4 V +2 CR +2 02/15/22, 22:34
-
Benni Mack merged patch set 5 02/15/22, 22:34
LinkVarsCalculator.php:129