Review main Merged

73526[BUGFIX] Initialize perms_clause before using

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 02/15/22, 20:14

Commit message

After some refactoring, the initialisation of the
perms_clause attribute ended up after
BU::readPageAccess, which receives this attribute
as an argument.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Nikita Hovratov uploaded patch set 1 02/15/22, 19:08

  2. core-ci voted on patch set 1 V +1 02/15/22, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23653

  3. Benjamin Franzke voted on patch set 1 CR +1 02/15/22, 19:19

  4. Benjamin Franzke voted on patch set 1 V +1 02/15/22, 19:24

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 02/15/22, 20:14

  6. Oli Bartsch merged patch set 2 02/15/22, 20:14