73528[TASK] Update typo3/testing-framework
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1216
-
Anja Leichsenring uploaded patch set 1 02/15/22, 19:43
-
Anja Leichsenring commented on patch set 1 02/15/22, 19:47
PR to testing-framework is here: https://github.com/TYPO3/testing-framework/pull/329 -
core-ci voted on patch set 1 V +1 02/15/22, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23655
-
Anja Leichsenring commented on patch set 1 02/15/22, 19:53
nightly run, too: https://git.typo3.org/typo3/CI/cms/-/pipelines/23657 -
Stefan Bürk commented on patch set 1 02/15/22, 20:13
Reply
FYI: Testing typo3/styleguide against your strict tf branch, too. https://github.com/sbuerk/styleguide/actions/runs/1849168128 -
core-ci voted on patch set 1 V -1 02/15/22, 20:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23657
-
Stefan Bürk commented on patch set 1 02/15/22, 20:28
Failed nightly seems not related to this change/tf change. These are the same errors failing last nightly also. I assume no-one had looked into the nightly failures yet. -
Anja Leichsenring commented on patch set 1 02/15/22, 20:31
Reply
currently doing so, but I don't think I will do anything about it tonight. Those are position failures, nothing severe. Thanks for checking, though. -
Christian Kuhn uploaded patch set 2 02/16/22, 20:30
-
Christian Kuhn updated the commit message in patch set 3 02/16/22, 20:38
-
core-ci voted on patch set 2 V +1 02/16/22, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23746
-
core-ci voted on patch set 3 V +1 02/16/22, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23747
-
Christian Kuhn voted on patch set 3 V +1 CR +1 02/16/22, 20:49
-
Stefan Bürk voted on patch set 3 V +1 CR +1 02/16/22, 20:53
-
Christian Kuhn voted on patch set 3 V +2 CR +2 02/16/22, 20:54
-
Christian Kuhn merged patch set 4 02/16/22, 20:55