Review main Merged

73528[TASK] Update typo3/testing-framework

Anja Leichsenring CR +2 V +2 Easy +4 −4 updated 02/16/22, 20:55

Commit message

Current typo3/testing-framework is more strict.

> composer u typo3/testing-framework

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1216

  1. Anja Leichsenring uploaded patch set 1 02/15/22, 19:43

  2. Anja Leichsenring commented on patch set 1 02/15/22, 19:47

  3. core-ci voted on patch set 1 V +1 02/15/22, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23655

  4. Anja Leichsenring commented on patch set 1 02/15/22, 19:53

  5. Stefan Bürk commented on patch set 1 02/15/22, 20:13

    Reply

    FYI: Testing typo3/styleguide against your strict tf branch, too. https://github.com/sbuerk/styleguide/actions/runs/1849168128
  6. core-ci voted on patch set 1 V -1 02/15/22, 20:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23657

  7. Stefan Bürk commented on patch set 1 02/15/22, 20:28

    Failed nightly seems not related to this change/tf change. These are the same errors failing last nightly also. I assume no-one had looked into the nightly failures yet.
  8. Anja Leichsenring commented on patch set 1 02/15/22, 20:31

    Reply

    currently doing so, but I don't think I will do anything about it tonight. Those are position failures, nothing severe. Thanks for checking, though.
  9. Christian Kuhn uploaded patch set 2 02/16/22, 20:30

  10. Christian Kuhn updated the commit message in patch set 3 02/16/22, 20:38

  11. core-ci voted on patch set 2 V +1 02/16/22, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23746

  12. core-ci voted on patch set 3 V +1 02/16/22, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23747

  13. Christian Kuhn voted on patch set 3 V +1 CR +1 02/16/22, 20:49

  14. Stefan Bürk voted on patch set 3 V +1 CR +1 02/16/22, 20:53

  15. Christian Kuhn voted on patch set 3 V +2 CR +2 02/16/22, 20:54

  16. Christian Kuhn merged patch set 4 02/16/22, 20:55