Review main Merged

73530[TASK] Change merge order of new content element wizard defVals

Oli Bartsch CR +2 V +2 Easy +8 −8 updated 02/16/22, 10:50

Commit message

The new content element wizard is using default values
to define on which colPos or in which language the new
element should be created.

Using TSconfig it is also possible to define custom default
values, most commonly the "CType". The user defined values
should however never overwrite the dynamically generated
values from the UI.

Therefore, the dynamic values do now always overwrite
the user defined values, like it's already done on preparing
the data map (In case "saveAndClose" is used).

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Oli Bartsch uploaded patch set 1 02/15/22, 20:52

  2. core-ci voted on patch set 1 V +1 02/15/22, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23660

  3. Stefan Bürk voted on patch set 1 CR +1 02/15/22, 22:51

  4. Jochen Roth voted on patch set 1 V +1 CR +1 02/16/22, 09:40

  5. Benni Mack voted on patch set 1 V +1 CR +1 02/16/22, 10:35

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 02/16/22, 10:50

  7. Oli Bartsch merged patch set 2 02/16/22, 10:50