Review 11.5 Merged

73544[BUGFIX] Fix PHP 8.1 warning in StoragePermissionsAspect

Benni Mack CR +2 V +2 Easy +5 −33 updated 02/19/22, 21:46

Commit message

BackendUserAuthentication isn't an injectable service,
therefore the (unused) dependency injection is dropped
and $GLOBALS['BE_USER'] usage is moved to be scoped
by the isBackend() check.

Also fix the same DI-anti-pattern in CategoryPermissionsAspect.
No user facing error is currently known for this case,
as the ModifyTreeDataEvent is only executed in backend
context, so this is just to streamline both aspects.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benni Mack commented on patch set 1 02/18/22, 16:02

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/18/22, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23884

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 02/19/22, 21:46

  4. Benjamin Franzke merged patch set 2 02/19/22, 21:46