Review 11.5 Merged

73550[BUGFIX] Ignore empty values for table and uid in FilesContentObject

Oli Bartsch CR +2 V +2 Normal +154 −7 updated 02/21/22, 23:27

Commit message

When using the option "references" as an array, it
is possible to provide table and uid with stdWrap
functionality. The return type can be mixed so
proper casting is necessary.

Also, empty values like an empty string for table or
"0" for uid should not trigger
$pageRepository->getRawRecord and the fallback
values should be used instead.

Another potential bug was found while adding test
cases, where an empty table would result in nothing.
In such a case, the current table should be used for
relation fetching.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Oli Bartsch commented on patch set 1 02/21/22, 23:08

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/21/22, 23:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24018

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 02/21/22, 23:27

  4. Oli Bartsch merged patch set 2 02/21/22, 23:27