Review main Merged

73552[BUGFIX] Prevent JS exception on using "Show hidden content"

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 02/15/22, 22:37

Commit message

A JavaScript exception is fixed by replacing
the invalid "auto" option for the "size" attribute
of the custom "typo3-backend-icon" element
with "small".

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 02/15/22, 21:23

  2. core-ci voted on patch set 1 V +1 02/15/22, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23665

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 02/15/22, 22:22

  4. Benni Mack voted on patch set 1 V +1 CR +1 02/15/22, 22:26

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 02/15/22, 22:37

  6. Oli Bartsch merged patch set 2 02/15/22, 22:37