Review main Merged

73555[TASK] Use proper type hints in PageArguments

Stefan Bürk CR +2 V +2 Normal +13 −60 updated 02/16/22, 14:45

Commit message

Argument and return type hints are aligned to match
implemented interface \ArrayAccess with proper type
hints and removing the '#[\ReturnTypeWillChange]'
attribute, which has been used as a workaround.

Most methods and the constructor already had proper
type hints with the exception of the interface methods,
which is now aligned. Class properties have also been
set to proper type hints along the way.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 69

  1. Stefan Bürk uploaded patch set 1 02/15/22, 22:04

  2. core-ci voted on patch set 1 V +1 02/15/22, 22:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23671

  3. Stefan Bürk uploaded patch set 2 02/16/22, 10:52

  4. core-ci voted on patch set 2 V +1 02/16/22, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23708

  5. Christian Kuhn updated the commit message in patch set 3 02/16/22, 13:45

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 02/16/22, 13:45

  7. core-ci voted on patch set 3 V +1 02/16/22, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23725

  8. Anja Leichsenring voted on patch set 3 V +2 CR +2 02/16/22, 14:45

  9. Anja Leichsenring merged patch set 4 02/16/22, 14:45