Review main Merged

73557[TASK] Simplify code in TSFE->getPageAndRootlineWithDomain

Benni Mack CR +2 V +2 Normal +28 −39 updated 02/16/22, 12:08

Commit message

Some code related to times without Site handling
is cleaned up and logically arranged.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 02/15/22, 22:52

  2. core-ci voted on patch set 1 V -1 02/15/22, 23:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23689

  3. Benni Mack uploaded patch set 2 02/16/22, 07:11

  4. Stefan Bürk rebased onto patch set 3 02/16/22, 09:50

  5. Stefan Bürk commented on patch set 3 02/16/22, 10:00

    patchset 2 pipeline was green, but not "voted" here. Thus the simply rebase to kick-off a new ci run.
  6. core-ci voted on patch set 3 V +1 02/16/22, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23706

  7. Stefan Bürk voted on patch set 3 V +1 CR +1 02/16/22, 10:05

  8. Christian Kuhn voted on patch set 3 V +2 CR +2 02/16/22, 12:08

  9. Christian Kuhn merged patch set 4 02/16/22, 12:08