Review main Merged Breaking

73558[!!!][FEATURE] Replace headerNoCache with PSR-14 event

Benni Mack CR +2 V +2 Normal +177 −37 updated 02/22/22, 07:29

Commit message

TSFE->headerNoCache() and the Event in there is replaced
with a new PSR-14 event and a protected method.

In addition, the "cacheContentFlag" property has now been
renamed into "pageContentWasLoadedFromCache".

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1016

  1. Benni Mack uploaded patch set 1 02/16/22, 07:33

  2. core-ci voted on patch set 1 V -1 02/16/22, 07:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23704

  3. Benni Mack uploaded patch set 2 02/16/22, 12:25

  4. core-ci voted on patch set 2 V -1 02/16/22, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23716

  5. Benni Mack uploaded patch set 3 02/16/22, 12:36

  6. core-ci voted on patch set 3 V -1 02/16/22, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23717

  7. Benni Mack uploaded patch set 4 02/16/22, 16:28

  8. core-ci voted on patch set 4 V +1 02/16/22, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23736

  9. Benni Mack updated the commit message in patch set 5 02/18/22, 17:03

  10. core-ci voted on patch set 5 V +1 02/18/22, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23887

  11. Benni Mack uploaded patch set 6 02/21/22, 19:43

  12. core-ci voted on patch set 6 V +1 02/21/22, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24007

  13. Oli Bartsch voted on patch set 6 V +1 CR +1 02/21/22, 19:57

  14. Stefan Bürk voted on patch set 6 V +1 CR +1 02/22/22, 04:04

  15. Benjamin Franzke voted on patch set 6 V +2 CR +2 02/22/22, 07:29

  16. Benjamin Franzke merged patch set 7 02/22/22, 07:29