73559[BUGFIX] Fix RTE link browser js error
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1113
-
Benjamin Franzke uploaded patch set 1 02/16/22, 11:01
-
core-ci voted on patch set 1 V +1 02/16/22, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23710
-
Benni Mack commented on patch set 1 CR +1 02/16/22, 11:26
nice catch! -
Benjamin Franzke commented on patch set 1 02/16/22, 11:28
Reply
thx to lolli for reporting this. Although I'd love to have 73522: [TASK] Use @typo3/ as ES6 module namespace | https://review.typo3.org/c/Packages/TYPO3.CMS/+/73522 merged first, and rather rebase this one later then. but well, we'll see. -
Benni Mack voted on patch set 1 V +1 02/16/22, 11:46
-
Georg Ringer commented on patch set 1 02/16/22, 12:16
merged now ;) -
Oli Bartsch commented on patch set 1 V -1 02/16/22, 12:33
Maybe I'm doing sth wrong, but now I get following exception: > es-module-shims.js:1 Uncaught (in promise) Error: Unable to resolve specifier > 'TYPO3/CMS/Backend/Modal.js' from https://main.ddev.site/typo3/record/ > at Je (es-module-shims.js:1:29591) > at be (es-module-shims.js:1:7582) -
Oli Bartsch uploaded patch set 2 02/16/22, 12:49
-
Oli Bartsch commented on patch set 2 V +1 CR +1 02/16/22, 12:50
Reply
Overlooked that the patch was not yet rebased. Works now. -
core-ci voted on patch set 2 V +1 02/16/22, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23718
-
Benni Mack voted on patch set 2 V +1 CR +1 02/16/22, 13:31
-
Christian Kuhn voted on patch set 2 V +2 CR +2 02/16/22, 13:38
-
Christian Kuhn merged patch set 3 02/16/22, 13:38