Review main Merged

73560[BUGFIX] Fix system maintainers modal in backend context

Benjamin Franzke CR +2 V +2 Easy +3 −0 updated 02/16/22, 13:51

Commit message

With the recent ES6 changes, the EXT:install JavaScript modules
could no longer be loaded into the main backend frame, as the
importmap configuration was not tagged to be included there.

Add the backend.module tag to the EXT:install importmap
in order for  TYPO3/CMS/Install/chosen.jquery.min.js to be
loadable for the system maintainer modal in backend context.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Benjamin Franzke uploaded patch set 1 02/16/22, 11:18

  2. core-ci voted on patch set 1 V +1 02/16/22, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23712

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 02/16/22, 13:41

  4. Benni Mack voted on patch set 1 V +1 CR +1 02/16/22, 13:45

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 02/16/22, 13:50

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 02/16/22, 13:51

  7. Christian Kuhn merged patch set 2 02/16/22, 13:51