Review main Merged

73561[TASK] Simplify usages of LanguageService->sL

Benni Mack CR +2 V +2 Normal +47 −93 updated 02/16/22, 17:25

Commit message

A few places still manually check for "LLL:" as
prefix. This is now resolved, as all of this is
already done in LanguageService directly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1115

  1. Benni Mack uploaded patch set 1 02/16/22, 13:18

  2. core-ci voted on patch set 1 V -1 02/16/22, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23719

  3. Benni Mack uploaded patch set 2 02/16/22, 13:40

  4. Benni Mack uploaded patch set 3 02/16/22, 13:40

  5. core-ci voted on patch set 2 V +1 02/16/22, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23723

  6. Christian Kuhn commented on patch set 3 02/16/22, 13:50

    Status.php:202

    does this depend on how 3rd party status are registered? if so, the getLL fallback may need to be kept?
  7. core-ci voted on patch set 3 V +1 02/16/22, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23724

  8. Benni Mack commented on patch set 3 CR -1 02/16/22, 15:54

    Status.php:202 Reply

    Yes. looks like we need to keep this :(
  9. Benni Mack uploaded patch set 4 02/16/22, 16:21

  10. Benni Mack commented on patch set 3 CR -1 02/16/22, 16:21

    Status.php:202 Reply

    Done
  11. core-ci voted on patch set 4 V +1 02/16/22, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23734

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 02/16/22, 17:22

  13. Stefan Bürk voted on patch set 4 V +1 CR +1 02/16/22, 17:24

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 02/16/22, 17:25

  15. Christian Kuhn merged patch set 5 02/16/22, 17:25