Review main Merged

73565[TASK] Avoid @inheritdoc annotations

Christian Kuhn CR +2 V +2 Hard +2 −331 updated 02/16/22, 18:39

Commit message

The @inheritdoc annotation is essentially useless
since it adds no value to code readers especially
in more and more strict environments. Static
code analyzers use doc header annotations from
parent classes or interfaces anyways.

The patch removes all @inheritdoc annotations
throughout the core and removes @inheritdoc from
the 'allowed annotation' list in CI.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Files 38

Show 18 more files

Review log 710

  1. Christian Kuhn uploaded patch set 1 02/16/22, 17:58

  2. Christian Kuhn updated the commit message in patch set 2 02/16/22, 18:07

  3. core-ci voted on patch set 1 V +1 02/16/22, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23740

  4. core-ci voted on patch set 2 V +1 02/16/22, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23741

  5. Christian Kuhn updated the commit message in patch set 3 02/16/22, 18:31

  6. Jochen Roth voted on patch set 3 V +1 CR +1 02/16/22, 18:32

  7. Stefan Bürk voted on patch set 3 V +1 CR +1 02/16/22, 18:36

  8. core-ci voted on patch set 3 V +1 02/16/22, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23742

  9. Georg Ringer voted on patch set 3 V +2 CR +2 02/16/22, 18:39

  10. Georg Ringer merged patch set 4 02/16/22, 18:39