Review main Merged

73567[BUGFIX] Fix cached importmap dependency resolution

Benjamin Franzke CR +2 V +2 Easy +3 −2 updated 02/18/22, 12:44

Commit message

The importmap dependencies were not correctly resolved
as the importmap has not been stored into $this->importMaps
when loaded from the assets cache.

Do properly store the value into $this->importMaps
in getFromCache and actually always use getImportMaps()
wrapper to avoid using the importMaps property that is
null by default.

This fixed for example the RTE external url link browser
that missed the configuration for the EXT:backend importmap.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Benjamin Franzke uploaded patch set 1 02/16/22, 20:56

  2. core-ci voted on patch set 1 V +1 02/16/22, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23750

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 02/18/22, 00:00

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 02/18/22, 08:33

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 02/18/22, 12:44

  6. Benjamin Franzke merged patch set 2 02/18/22, 12:44