Review main Merged

73569[TASK] Avoid additional query in TSFE for BE User Sections

Benni Mack CR +2 V +2 Easy +5 −27 updated 02/17/22, 14:25

Commit message

This is a nice one: One of the most underrated features
(pages within Backend User Sections), is checked
within TSFE, if a logged-in backend user has access
to the current page.

This change uses the current "TSFE->page" record
to do the check and avoids 1 additional SQL query.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 02/16/22, 22:27

  2. Benni Mack updated the commit message in patch set 2 02/16/22, 22:29

  3. core-ci voted on patch set 1 V +1 02/16/22, 22:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23761

  4. core-ci voted on patch set 2 V +1 02/16/22, 22:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23762

  5. Oli Bartsch commented on patch set 2 V +1 CR +1 02/17/22, 13:35

    Nice catch.
  6. Stefan Bürk voted on patch set 2 CR +1 02/17/22, 14:12

  7. Stefan Bürk voted on patch set 2 V +1 02/17/22, 14:17

  8. Benni Mack voted on patch set 2 V +2 CR +2 02/17/22, 14:25

  9. Benni Mack merged patch set 3 02/17/22, 14:25