Review main Merged

73570[BUGFIX] Avoid PHP 8.0 undefined key in FormEngine

TYPO3com CR +2 V +2 Easy +1 −1 updated 02/17/22, 10:38

Commit message

FlexFormSectionContainer raises an exception when
title is not defined.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 58

  1. TYPO3com uploaded patch set 1 02/16/22, 23:31

  2. core-ci voted on patch set 1 V +1 02/16/22, 23:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23766

  3. Christian Kuhn updated the commit message in patch set 2 02/17/22, 08:45

  4. Christian Kuhn commented on patch set 2 V +1 CR +1 02/17/22, 08:46

    looks legit and should be safe.
  5. core-ci voted on patch set 2 V +1 02/17/22, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23776

  6. Oliver Klee voted on patch set 2 CR +1 02/17/22, 10:28

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 02/17/22, 10:38

  8. Oli Bartsch merged patch set 3 02/17/22, 10:38