Review main Merged

73571[BUGFIX] Fix type error in t3editor code completion controller

Benjamin Franzke CR +2 V +2 Easy +1 −0 updated 02/17/22, 13:41

Commit message

With #96849 t3editor classes have been declared strictly typed.
TemplateService converts keys interpretable as integer into
real integers and therefore any usage with string based
functions need to convert the values to string data type.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Benjamin Franzke uploaded patch set 1 02/17/22, 06:44

  2. core-ci voted on patch set 1 V -1 02/17/22, 06:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23774

  3. Benjamin Franzke uploaded patch set 2 02/17/22, 06:56

  4. core-ci voted on patch set 2 V +1 02/17/22, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23775

  5. Christian Kuhn commented on patch set 2 02/17/22, 08:43

    CodeCompletionController.php:93

    $key = (string)$key would be enough here, would it?
  6. Benjamin Franzke commented on patch set 2 02/17/22, 09:22

    CodeCompletionController.php:93 Reply Unresolved

    would be enough yea, but I disliked that those casts do not reveal, *why* we cast. And i prefer explicit code over (possibly outdated) comments here. This makes it explicit that cast because of possible integers.
  7. Nikita Hovratov voted on patch set 2 V +1 CR +1 02/17/22, 10:18

  8. Oliver Klee voted on patch set 2 CR +1 02/17/22, 10:27

  9. Oli Bartsch voted on patch set 2 V +1 CR +1 02/17/22, 10:46

  10. Benjamin Franzke voted on patch set 2 V +2 CR +2 02/17/22, 13:40

  11. Benjamin Franzke merged patch set 3 02/17/22, 13:41