73571[BUGFIX] Fix type error in t3editor code completion controller
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Oliver Klee +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 1
Review log 911
-
Benjamin Franzke uploaded patch set 1 02/17/22, 06:44
-
core-ci voted on patch set 1 V -1 02/17/22, 06:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23774
-
Benjamin Franzke uploaded patch set 2 02/17/22, 06:56
-
core-ci voted on patch set 2 V +1 02/17/22, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23775
-
Christian Kuhn commented on patch set 2 02/17/22, 08:43
-
Benjamin Franzke commented on patch set 2 02/17/22, 09:22
CodeCompletionController.php:93Reply Unresolvedwould be enough yea, but I disliked that those casts do not reveal, *why* we cast. And i prefer explicit code over (possibly outdated) comments here. This makes it explicit that cast because of possible integers. -
Nikita Hovratov voted on patch set 2 V +1 CR +1 02/17/22, 10:18
-
Oliver Klee voted on patch set 2 CR +1 02/17/22, 10:27
-
Oli Bartsch voted on patch set 2 V +1 CR +1 02/17/22, 10:46
-
Benjamin Franzke voted on patch set 2 V +2 CR +2 02/17/22, 13:40
-
Benjamin Franzke merged patch set 3 02/17/22, 13:41
CodeCompletionController.php:93