Review main Merged

73576[BUGFIX] Replace wrong routeIdentifier in example code

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 02/17/22, 23:15

Commit message

Some code examples for the ShortcutButton
"routeIdentifier" property, introduced in #93093,
used the non existing "web_view" identifier.

Using this code example will therefore lead to
a RouteNotFoundException exception.

This is now fixed by using the correct identifier
for the viewpage module.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 79

  1. Oli Bartsch uploaded patch set 1 02/17/22, 11:58

  2. Oli Bartsch updated the commit message in patch set 2 02/17/22, 12:00

  3. core-ci voted on patch set 2 V +1 02/17/22, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23789

  4. core-ci voted on patch set 1 V +1 02/17/22, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23788

  5. Jochen Roth voted on patch set 2 V +1 CR +1 02/17/22, 16:49

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 02/17/22, 20:22

  7. Benni Mack voted on patch set 2 V +1 CR +1 02/17/22, 21:41

  8. Oli Bartsch voted on patch set 2 V +2 CR +2 02/17/22, 23:15

  9. Oli Bartsch merged patch set 3 02/17/22, 23:15