Review main Merged

73578[BUGFIX] Avoid autofocus on preselected useOrOverridePlaceholder fields

Benjamin Franzke CR +2 V +2 Easy +6 −5 updated 02/17/22, 14:48

Commit message

With #90879 useOrOverridePlaceholder fields have been adapted
to autofocus the related field when the related checkbox
(e.g in sys_file_references) are triggered in
FormEngine.toggleCheckboxField.

This has the side effect that input fields whose checkbox
is preselected are autofocused on initial page load, when
FormEngine.toggleCheckboxField() is called from
FormEngine.initializeNullWithPlaceholderCheckboxes.
This caused the browser to scroll to these fields.

The autofocus is now changed to not be triggered on
initial pageload, only when FormEngine.toggleCheckboxField()
is used due to user input.

This also had the effect that acceptance tests failed randomly as
automated tab-clicks didn't work (for example in #93629), when the
formengine iframe was scrolled all the way to the last
useOrOverridePlaceholder field, rendering the tab-selection invisible.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 710

  1. Benjamin Franzke uploaded patch set 1 02/17/22, 12:37

  2. core-ci voted on patch set 1 V +1 02/17/22, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23793

  3. Stefan Bürk commented on patch set 1 02/17/22, 13:13

    Here the pipeline for the startet nightly on this patch: https://git.typo3.org/typo3/CI/cms/-/pipelines/23797
  4. core-ci voted on patch set 1 V -1 02/17/22, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23797

  5. core-ci voted on patch set 1 V +1 02/17/22, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23797

  6. Stefan Bürk voted on patch set 1 V +1 CR +1 02/17/22, 13:41

  7. Benni Mack voted on patch set 1 V +1 CR +1 02/17/22, 14:37

  8. Nikita Hovratov voted on patch set 1 V +1 CR +1 02/17/22, 14:47

  9. Benjamin Franzke voted on patch set 1 V +2 CR +2 02/17/22, 14:48

  10. Benjamin Franzke merged patch set 2 02/17/22, 14:48