Review main Merged

73583[TASK] Streamline tab-handling in ElementsBasicInput cests

Benjamin Franzke CR +2 V +2 Easy +5 −17 updated 02/18/22, 06:35

Commit message

* Avoid scrollIntoView which is no longer needed since #96947

* Do not catch exceptions on tab-click in ElementsBasicInputRangeCest
  which has been introduced in #93629, but actually didn't catch the
  documented case where the tab was already active (no exception in
  that case). It was actually only triggered when the tab was
  scrolled away. Again no longer needed due to #96947.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 68

  1. Benjamin Franzke uploaded patch set 1 02/17/22, 15:08

  2. core-ci voted on patch set 1 V +1 02/17/22, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23812

  3. Stefan Bürk commented on patch set 1 02/17/22, 15:53

  4. core-ci commented on patch set 1 02/17/22, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23817

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 02/17/22, 18:49

  6. Oli Bartsch voted on patch set 1 V +1 CR +1 02/17/22, 20:17

  7. Benjamin Franzke voted on patch set 1 V +2 CR +2 02/18/22, 06:35

  8. Benjamin Franzke merged patch set 2 02/18/22, 06:35