Review 11.5 Merged

73586[TASK] Streamline tab-handling in ElementsBasicInput cests

Benjamin Franzke CR +2 V +2 Easy +5 −17 updated 02/18/22, 06:36

Commit message

* Avoid scrollIntoView which is no longer needed since #96947

* Do not catch exceptions on tab-click in ElementsBasicInputRangeCest
  which has been introduced in #93629, but actually didn't catch the
  documented case where the tab was already active (no exception in
  that case). It was actually only triggered when the tab was
  scrolled away. Again no longer needed due to #96947.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 59

  1. Benjamin Franzke uploaded patch set 1 02/17/22, 15:18

  2. core-ci voted on patch set 1 V +1 02/17/22, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23815

  3. Stefan Bürk commented on patch set 1 02/17/22, 16:32

  4. core-ci voted on patch set 1 V -1 02/17/22, 17:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23819

  5. core-ci commented on patch set 1 02/17/22, 18:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23819

  6. core-ci voted on patch set 1 V +1 02/17/22, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23819

  7. Stefan Bürk commented on patch set 1 V +1 CR +1 02/17/22, 18:50

    nightly red was normal hickup, unrelated to this patch.
  8. Benjamin Franzke voted on patch set 1 V +2 CR +2 02/18/22, 06:36

  9. Benjamin Franzke merged patch set 2 02/18/22, 06:36