73588[BUGFIX] Avoid deprecation in PHP 8.1 passing null value to HtmlViewHelper
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Markus Gerdes +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Gerdes +1
- core-ci +1 CI
Issues 1
Files 2
Review log 89
-
Chris Müller uploaded patch set 1 02/17/22, 16:24
-
core-ci voted on patch set 1 V +1 02/17/22, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23818
-
Oliver Klee voted on patch set 1 CR +1 02/18/22, 16:29
-
Benni Mack voted on patch set 1 V +1 CR +1 02/23/22, 08:13
-
Markus Gerdes voted on patch set 1 V +1 CR +1 02/24/22, 19:41
-
Benni Mack voted on patch set 1 V +2 CR +2 02/24/22, 20:08
-
Benni Mack merged patch set 2 02/24/22, 20:08
-
Christian Kuhn commented on patch set 2 02/24/22, 23:02
imho a fluid issue, see discussion on https://review.typo3.org/c/Packages/TYPO3.CMS/+/73589. -
Stefan Bürk commented on patch set 2 02/26/22, 21:45
Reply
Here it is not a registered argument, as in the other discussion. Here it is a general rendering children closure which can be "anything". It simple has a fallback if it is null to be string. Which I think is okay and legit, compared to the change in the linked patch of the other viewhelper.