Review main Merged

73594[TASK] Use dependency injection in PageRenderer

Benjamin Franzke CR +2 V +2 Hard +431 −182 updated 02/26/22, 20:01

Commit message

Add dependency injection to PageRenderer and it's direct
dependencies. Most prominently this avoids the static
assets-cache injection from TYPO3 bootstrap and refactors to
regular injection instead.
ResourceCompressor is adapted to be delay it's initialization
to be injectable without immediate side-effects.

Backend Router and UriBuilder are not injected because they are
a) only needed in backend context and
b) should ideally be moved out of the PageRenderer
   into EXT:backend anyway.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 1219

  1. Benjamin Franzke uploaded patch set 1 02/17/22, 19:03

  2. core-ci voted on patch set 1 V -1 02/17/22, 19:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23828

  3. Benjamin Franzke uploaded patch set 2 02/19/22, 07:16

  4. Benjamin Franzke wrote 02/19/22, 07:16

    Topic set to di
  5. core-ci voted on patch set 2 V -1 02/19/22, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23897

  6. Benjamin Franzke uploaded patch set 3 02/19/22, 08:49

  7. core-ci voted on patch set 3 V -1 02/19/22, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23898

  8. Benjamin Franzke uploaded patch set 4 02/19/22, 10:50

  9. core-ci voted on patch set 4 V +1 02/19/22, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23899

  10. Benjamin Franzke uploaded patch set 5 02/19/22, 11:08

  11. core-ci voted on patch set 5 V -1 02/19/22, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23900

  12. Benjamin Franzke uploaded patch set 6 02/19/22, 12:33

  13. core-ci voted on patch set 6 V +1 02/19/22, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23902

  14. Benjamin Franzke uploaded patch set 7 02/24/22, 18:33

  15. core-ci voted on patch set 7 V +1 02/24/22, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24220

  16. Benni Mack voted on patch set 7 V +1 CR +1 02/25/22, 16:40

  17. Stefan Bürk voted on patch set 7 V +1 CR +1 02/26/22, 19:03

  18. Benjamin Franzke voted on patch set 7 V +2 CR +2 02/26/22, 20:00

  19. Benjamin Franzke merged patch set 8 02/26/22, 20:01