73594[TASK] Use dependency injection in PageRenderer
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 18
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Classes/Core/BootService.php+0 −3
- typo3/sysext/core/Classes/Core/Bootstrap.php+0 −2
- typo3/sysext/core/Classes/Page/PageRenderer.php+57 −94
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+15 −4
- typo3/sysext/core/Classes/Service/MarkerBasedTemplateService.php+12 −28
- typo3/sysext/core/Configuration/Services.yaml+10 −0
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+29 −5
- typo3/sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.phpnew+79 −0
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+17 −6
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorIntegrationTest.php+9 −6
- typo3/sysext/core/Tests/Unit/Service/MarkerBasedTemplateServiceTest.php+4 −7
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+7 −4
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+7 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php+149 −4
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.php+21 −13
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+9 −1
- typo3/sysext/frontend/Tests/Unit/Plugin/AbstractPluginTest.php+6 −0
Review log 1219
-
Benjamin Franzke uploaded patch set 1 02/17/22, 19:03
-
core-ci voted on patch set 1 V -1 02/17/22, 19:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23828
-
Benjamin Franzke uploaded patch set 2 02/19/22, 07:16
-
Benjamin Franzke wrote 02/19/22, 07:16
Topic set to di -
core-ci voted on patch set 2 V -1 02/19/22, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23897
-
Benjamin Franzke uploaded patch set 3 02/19/22, 08:49
-
core-ci voted on patch set 3 V -1 02/19/22, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23898
-
Benjamin Franzke uploaded patch set 4 02/19/22, 10:50
-
core-ci voted on patch set 4 V +1 02/19/22, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23899
-
Benjamin Franzke uploaded patch set 5 02/19/22, 11:08
-
core-ci voted on patch set 5 V -1 02/19/22, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23900
-
Benjamin Franzke uploaded patch set 6 02/19/22, 12:33
-
core-ci voted on patch set 6 V +1 02/19/22, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23902
-
Benjamin Franzke uploaded patch set 7 02/24/22, 18:33
-
core-ci voted on patch set 7 V +1 02/24/22, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24220
-
Benni Mack voted on patch set 7 V +1 CR +1 02/25/22, 16:40
-
Stefan Bürk voted on patch set 7 V +1 CR +1 02/26/22, 19:03
-
Benjamin Franzke voted on patch set 7 V +2 CR +2 02/26/22, 20:00
-
Benjamin Franzke merged patch set 8 02/26/22, 20:01