73599[BUGFIX] Resolve default value in f:translate on time
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1014
-
Oli Bartsch uploaded patch set 1 02/18/22, 11:03
-
Oli Bartsch updated the commit message in patch set 2 02/18/22, 11:03
-
core-ci voted on patch set 1 V +1 02/18/22, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23868
-
core-ci voted on patch set 2 V +1 02/18/22, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23869
-
Oli Bartsch commented on patch set 2 CR -1 02/18/22, 11:16
Will add a test -
Oli Bartsch uploaded patch set 3 02/18/22, 11:22
-
Oli Bartsch commented on patch set 3 CR -1 02/18/22, 11:29
Test currently not executed, on it. -
core-ci voted on patch set 3 V -1 02/18/22, 11:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23870
-
Oli Bartsch uploaded patch set 4 02/18/22, 11:54
-
core-ci voted on patch set 4 V +1 02/18/22, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23871
-
Christian Kuhn commented on patch set 4 V +1 CR +1 02/18/22, 12:32
good catch! we should add a -
Stefan Bürk commented on patch set 4 V +1 CR +1 02/18/22, 12:42
nice. Alternatively we "could" switch to "CompileWithContentArgumentAndRenderStatic" trait instead and add following method: ``` /** * Explicitly set argument name to be used as content. */ public function resolveContentArgumentName(): string { return 'default'; } ``` than we could simply use renderingChildrenClosure(). ``` $default = $renderChildrenClosure() ?? ''; ``` Comment of registerend argument already metionens this behaviour, which this trait is capable of (with magic) which can be manual hardend to a specific argument with this technic. Example: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73014/7/typo3/sysext/core/Classes/ViewHelpers/NormalizedUrlViewHelper.php#64 I will vote this as this is a legitim working patch, just wanted to throw the "alternative" into the comments. -
Oli Bartsch commented on patch set 4 V +2 CR +2 02/18/22, 12:55
Reply
Tbh, I don't see the benefit of such magic. -
Oli Bartsch merged patch set 5 02/18/22, 12:55