73604[TASK] Let PageRenderer render a PSR-7 response
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Stefan Bürk +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 15
- typo3/sysext/backend/Classes/Controller/BackendController.php+1 −2
- typo3/sysext/backend/Classes/Controller/LoginController.php+4 −5
- typo3/sysext/backend/Classes/Controller/MfaController.php+1 −2
- typo3/sysext/backend/Classes/Controller/MfaSetupController.php+6 −6
- typo3/sysext/backend/Classes/Controller/ResetPasswordController.php+4 −5
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+28 −22
- typo3/sysext/backend/Classes/Template/ModuleTemplateFactory.php+0 −6
- typo3/sysext/backend/Tests/Functional/Controller/MfaControllerTest.php+3 −3
- typo3/sysext/backend/Tests/Functional/Controller/MfaSetupControllerTest.php+3 −3
- typo3/sysext/backend/Tests/Functional/Controller/ResetPasswordControllerTest.php+6 −6
- typo3/sysext/core/Classes/Page/PageRenderer.php4+19 −0
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+4 −0
- typo3/sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.php+4 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/PageRendererViewHelperTest.php+6 −7
- typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php+1 −1
Review log 1521
-
Benjamin Franzke uploaded patch set 1 02/19/22, 11:08
-
core-ci voted on patch set 1 V -1 02/19/22, 11:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23901
-
Benjamin Franzke uploaded patch set 2 02/19/22, 12:33
-
core-ci voted on patch set 2 V -1 02/19/22, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23903
-
Benjamin Franzke uploaded patch set 3 02/19/22, 13:44
-
core-ci voted on patch set 3 V -1 02/19/22, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23904
-
Benjamin Franzke uploaded patch set 4 02/19/22, 14:07
-
core-ci voted on patch set 4 V +1 02/19/22, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23905
-
Benjamin Franzke uploaded patch set 5 02/24/22, 19:09
-
core-ci voted on patch set 5 V +1 02/24/22, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24224
-
Benjamin Franzke uploaded patch set 6 03/01/22, 14:08
-
core-ci voted on patch set 6 V +1 03/01/22, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24411
-
Oli Bartsch commented on patch set 6 V +1 CR +1 03/01/22, 19:33
-
Stefan Bürk commented on patch set 6 V +1 CR +1 03/01/22, 19:40
PageRenderer.php:1765ReplyGenerelly thought about that option/question too ... but I think it would only make sense if the contend/stream would be handed over too. Otherwise this should be a option but more a setting which is bound to the content which is rendered by "$this->render()" - or ? -
Christian Kuhn voted on patch set 6 CR -1 03/01/22, 19:44
-
Christian Kuhn voted on patch set 6 CR +1 03/01/22, 19:51
-
Benjamin Franzke commented on patch set 6 03/01/22, 20:13
PageRenderer.php:1765ReplyI thought about adding that as parameter as well, but somehow let it be, as HtmlResponse also didn't provide that. Other than that PageRenderer is really limited to HTML rendering, so it would only be useful to switch between text/html and application/xhtml+xml anyway. Now, looking at the PageRenderer related xhtml code I figure that PageRenderer currently mixes html and xhtml badly (we currently run in "xhtml" mode, but outputting html, for that reason we use ending slashes without having a need to). I'd probably streamline that in a separate patch and then it would be useful to render the ContentType based on $this->renderXhtml, but currently we can't do that as we run with $this->renderXhtml = true, and that is wrong, as we render html. -
Benni Mack voted on patch set 6 CR +1 03/02/22, 08:57
-
Oli Bartsch commented on patch set 6 03/02/22, 09:05
PageRenderer.php:1765ReplyDone -
Benjamin Franzke voted on patch set 6 V +2 CR +2 03/02/22, 09:12
-
Benjamin Franzke merged patch set 7 03/02/22, 09:12
PageRenderer.php:1765